Skip to content

Commit 812f8ce

Browse files
committed
changing ready() logic for FeatureSet
1 parent b765856 commit 812f8ce

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/workbench/core/artifacts/data_source_abstract.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def expected_meta(self) -> list[str]:
259259
def ready(self) -> bool:
260260
"""Is the DataSource ready?"""
261261

262-
# Check if the Artifact is ready
262+
# Check if our parent class (Artifact) is ready
263263
if not super().ready():
264264
return False
265265

src/workbench/core/artifacts/feature_set_core.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -614,12 +614,8 @@ def ready(self) -> bool:
614614
Note: Since FeatureSet is a composite of DataSource and FeatureGroup, we need to
615615
check both to see if the FeatureSet is ready."""
616616

617-
# Check the expected metadata for the FeatureSet
618-
expected_meta = self.expected_meta()
619-
existing_meta = self.workbench_meta()
620-
feature_set_ready = set(existing_meta.keys()).issuperset(expected_meta)
621-
if not feature_set_ready:
622-
self.log.info(f"FeatureSet {self.name} is not ready!")
617+
# Check if our parent class (Artifact) is ready
618+
if not super().ready():
623619
return False
624620

625621
# Okay now call/return the DataSource ready() method

0 commit comments

Comments
 (0)