[TASK] Declare nullable types as nullable explicitly (#332)

@see https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

Co-authored-by: Benjamin Kott <[email protected]>

Author: julianhofmann

Classes/Controller/BackendController.php

@@ -85,7 +85,7 @@ public function setupWizardAction(): ResponseInterface
         return $view->renderResponse('Backend/SetupWizard');
     }
 
-    public function postsAction(int $blogSetup = null): ResponseInterface
+    public function postsAction(?int $blogSetup = null): ResponseInterface
     {
         $query = $this->postRepository->createQuery();
         $querySettings = $query->getQuerySettings();
@@ -102,7 +102,7 @@ public function postsAction(int $blogSetup = null): ResponseInterface
         return $view->renderResponse('Backend/Posts');
     }
 
-    public function commentsAction(string $filter = null, int $blogSetup = null): ResponseInterface
+    public function commentsAction(?string $filter = null, ?int $blogSetup = null): ResponseInterface
     {
         $view = $this->moduleTemplateFactory->create($this->request);
         $view->assignMultiple([
@@ -122,7 +122,7 @@ public function commentsAction(string $filter = null, int $blogSetup = null): Re
         return $view->renderResponse('Backend/Comments');
     }
 
-    public function updateCommentStatusAction(string $status, string $filter = null, int $blogSetup = null, array $comments = [], int $comment = null): ResponseInterface
+    public function updateCommentStatusAction(string $status, ?string $filter = null, ?int $blogSetup = null, array $comments = [], ?int $comment = null): ResponseInterface
     {
         if ($comment !== null) {
             $comments['__identity'][] = $comment;
@@ -155,7 +155,7 @@ public function updateCommentStatusAction(string $status, string $filter = null,
         return new RedirectResponse($this->uriBuilder->reset()->uriFor('comments', ['filter' => $filter, 'blogSetup' => $blogSetup]));
     }
 
-    public function createBlogAction(array $data = null): ResponseInterface
+    public function createBlogAction(?array $data = null): ResponseInterface
     {
         if ($data !== null && $this->setupService->createBlogSetup($data)) {
             $this->addFlashMessage('Your blog setup has been created.', 'Congratulation');

Classes/Domain/Repository/CommentRepository.php

@@ -56,7 +56,7 @@ public function findAllByPost(Post $post): QueryResultInterface
         return $result;
     }
 
-    public function findAllByFilter(string $filter = null, int $blogSetup = null): QueryResultInterface
+    public function findAllByFilter(?string $filter = null, ?int $blogSetup = null): QueryResultInterface
     {
         $query = $this->createQuery();
         $querySettings = $query->getQuerySettings();
@@ -93,7 +93,7 @@ public function findAllByFilter(string $filter = null, int $blogSetup = null): Q
         return $this->createQuery()->execute();
     }
 
-    public function findActiveComments(int $limit = null, int $blogSetup = null): QueryResultInterface
+    public function findActiveComments(?int $limit = null, ?int $blogSetup = null): QueryResultInterface
     {
         $query = $this->createQuery();
 

Classes/Domain/Repository/PostRepository.php

@@ -226,7 +226,7 @@ public function findAllByTag(Tag $tag): QueryResultInterface
         return $query->matching($query->logicalAnd(...$constraints))->execute();
     }
 
-    public function findByMonthAndYear(int $year, int $month = null): QueryResultInterface
+    public function findByMonthAndYear(int $year, ?int $month = null): QueryResultInterface
     {
         $query = $this->createQuery();
         $constraints = $this->defaultConstraints;

Tests/Unit/Service/Avatar/Gravatar/GravatarUriBuilderTest.php

@@ -10,6 +10,8 @@
 
 namespace T3G\AgencyPack\Blog\Tests\Unit\Service\Avatar\Gravatar;
 
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
 use T3G\AgencyPack\Blog\Service\Avatar\Gravatar\GravatarUriBuilder;
 use TYPO3\CMS\Core\Http\UriFactory;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
@@ -28,23 +30,17 @@ protected function setUp(): void
         $this->gravatarUriBuilder = new GravatarUriBuilder(new UriFactory());
     }
 
-    /**
-     * @dataProvider testGetUriDataProvider
-     * @param string $expectedUriString
-     * @param string $email
-     * @param int|null $size
-     * @param string|null $rating
-     * @param string|null $default
-     */
-    public function testGetUri(string $expectedUriString, string $email, ?int $size, ?string $rating, ?string $default): void
+    #[Test]
+    #[DataProvider('getUriDataProvider')]
+    public function getUri(string $expectedUriString, string $email, ?int $size, ?string $rating, ?string $default): void
     {
         self::assertSame(
             $expectedUriString,
             (string)$this->gravatarUriBuilder->getUri($email, $size, $rating, $default)
         );
     }
 
-    public static function testGetUriDataProvider(): \Generator
+    public static function getUriDataProvider(): \Generator
     {
         $email = '[email protected]';
         yield ['https://www.gravatar.com/avatar/71803b16fcdb8ac77611d0a977b20164', $email, null, null, null];