Skip to content

Commit c230ce5

Browse files
committed
fix: do not include full function calls in reference queries
1 parent f5b3ab8 commit c230ce5

File tree

5 files changed

+1
-44
lines changed

5 files changed

+1
-44
lines changed

lua/refactoring/config.lua

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,6 +811,7 @@ print_var_code_generation.print_var.cpp = print_var_code_generation.print_var.c
811811
print_var_code_generation.print_var.typescript = print_var_code_generation.print_var.javascript
812812
print_var_code_generation.print_var.tsx = print_var_code_generation.print_var.javascript
813813

814+
-- TODO: add support for all of the languages in print_var (the queries are already there)
814815
---@type refactor.print_loc.CodeGeneration
815816
local print_loc_code_generation = {
816817
print_loc = {

queries/c/refactor_reference.scm

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -106,23 +106,12 @@
106106
(#set! reference_type read)
107107
(#set! function_call_identifier true))
108108

109-
; TODO: these (are similartly in other languages like lua) are not really
110-
; identifiers. Should I compute them in some other way?
111-
(call_expression
112-
(identifier)
113-
(#set! reference_type read)) @reference.identifier
114-
115109
(call_expression
116110
(field_expression) @reference.identifier
117111
(#set! reference_type read)
118112
(#set! field true)
119113
(#set! function_call_identifier true))
120114

121-
(call_expression
122-
(field_expression)
123-
(#set! reference_type read)
124-
(#set! field true)) @reference.identifier
125-
126115
(function_definition
127116
declarator: (function_declarator
128117
declarator: (identifier) @reference.identifier)

queries/ecma/refactor_reference.scm

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -69,29 +69,17 @@
6969
(#set! reference_type read)
7070
(#set! field true)) @reference.identifier
7171

72-
; TODO: remove the full function call everywhere, filter out references that
73-
; are function calls (I may be already doing this). `print_exp` will be used to
74-
; print function calls
7572
(call_expression
7673
function: (identifier) @reference.identifier
7774
(#set! reference_type read)
7875
(#set! function_call_identifier true))
7976

80-
(call_expression
81-
function: (identifier)
82-
(#set! reference_type read)) @reference.identifier
83-
8477
(call_expression
8578
function: (member_expression) @reference.identifier
8679
(#set! reference_type read)
8780
(#set! field true)
8881
(#set! function_call_identifier true))
8982

90-
(call_expression
91-
function: (member_expression)
92-
(#set! reference_type read)
93-
(#set! field true)) @reference.identifier
94-
9583
(function_declaration
9684
name: (_) @reference.identifier
9785
(#set! declaration true)

queries/go/refactor_reference.scm

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,6 @@
150150
(#set! reference_type read)
151151
(#set! function_call_identifier true))
152152

153-
(call_expression
154-
function: (identifier)
155-
(#set! reference_type read)) @reference.identifier
156-
157153
(call_expression
158154
function: [
159155
(selector_expression)
@@ -163,14 +159,6 @@
163159
(#set! field true)
164160
(#set! function_call_identifier true))
165161

166-
(call_expression
167-
function: [
168-
(selector_expression)
169-
(index_expression)
170-
]
171-
(#set! reference_type read)
172-
(#set! field true)) @reference.identifier
173-
174162
(if_statement
175163
condition: (identifier) @reference.identifier
176164
(#set! reference_type read))

queries/lua/refactor_reference.scm

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,6 @@
9696
(#set! field true)
9797
(#set! function_call_identifier true))
9898

99-
(function_call
100-
[
101-
(method_index_expression)
102-
(dot_index_expression)
103-
(bracket_index_expression)
104-
]
105-
(#set! reference_type read)
106-
(#set! field true)) @reference.identifier
107-
10899
(expression_list
109100
(identifier) @reference.identifier
110101
(#set! reference_type read))

0 commit comments

Comments
 (0)