Skip to content

cmake: remove jpeg sources from our repo and use turbojpeg instead #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
flsobral wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

cmake: remove jpeg sources from our repo and use turbojpeg instead #316

flsobral wants to merge 19 commits into from

Conversation

@flsobral
Copy link
Member

@flsobral flsobral commented Mar 10, 2021

No description provided.

@flsobral flsobral self-assigned this Mar 10, 2021
flsobral added 15 commits March 10, 2021 19:25
@flsobral
jpeg: removes wrong usage of jpeg sample cdjpeg code
1485866
@flsobral
jpeg: disables usage of heap inside the jpeg error struct
e974309 
we'll have to find another way of using the heap with the jpeg
error handling
@flsobral
jpeg: removes the jpeg source code
4f87947 
Adds jdatadst_tc and jdatasrc_tc, based on the original ones for the stdio,
but for usage with totalcross.io.File. That way we can use our own input
without messing with the library internals.
@flsobral
cmake: trying another way of referencing the library
f7b3c17
@flsobral
cmake: use makefile for android
a92a06c
@flsobral
cmake: maybe I need to escape for the expression?
56b8eaf
@flsobral
cmake: maybe without quotes?
88adc08
@flsobral
cmake: using a variable?
8181388
@flsobral
cmake: to hell with generator expressions
ffd28a9
@flsobral
cmake: fix target for android, will probably break the others
8b984cd
@flsobral
android: use maven central instead of jcenter
5109f55
@flsobral
android: stupid jcenter
26b9315
@flsobral
cicd: update docker images version
ceba9f1
@flsobral
cicd: update docker images version
8e2964b
@flsobral
cicd: update docker images version
16dbc91
@flsobral
Copy link
Member Author

flsobral commented Mar 16, 2021

OMG this is happening! Almost there!

@flsobral
Copy link
Member Author

flsobral commented Mar 17, 2021

results observed using a 2500x1095 image on a iMX6ULL:

  • loading the image at full size: 50% faster
  • using Image.getJpegBestFit to load the image at 1250x548: 20% faster

@flsobral flsobral linked an issue Mar 19, 2021 that may be closed by this pull request
Remove libjpeg sources from repo and use turbojpeg instead #319
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@flsobral flsobral

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove libjpeg sources from repo and use turbojpeg instead

2 participants

@flsobral