Fix issue with downloads moving after restart (#8699)

Author: egbertbouman

src/tribler/core/libtorrent/download_manager/download_config.py

@@ -192,11 +192,12 @@ def set_completed_dir(self, path: Path | str) -> None:
         """
         self.config["download_defaults"]["completed_dir"] = str(path)
 
-    def get_completed_dir(self) -> str | None:
+    def get_completed_dir(self) -> Path | None:
         """
         Gets the directory where to move this Download upon completed.
         """
-        return self.config["download_defaults"].get("completed_dir")
+        completed_dir = self.config["download_defaults"].get("completed_dir")
+        return Path(completed_dir) if completed_dir else None
 
     def set_hops(self, hops: int) -> None:
         """

src/tribler/core/libtorrent/restapi/downloads_endpoint.py

@@ -329,7 +329,7 @@ async def get_downloads(self, request: Request) -> RESTResponse:
                 "upload_limit": download.get_upload_limit(),
                 "download_limit": download.get_download_limit(),
                 "destination": str(download.config.get_dest_dir()),
-                "completed_dir": download.config.get_completed_dir(),
+                "completed_dir": str(download.config.get_completed_dir() or ""),
                 "total_pieces": tdef.torrent_info.num_pieces() if tdef.torrent_info else 0,
                 "error": repr(state.get_error()) if state.get_error() else "",
                 "time_added": download.config.get_time_added(),