Inconsistent behaviour in recent library upgrade.

[hickscorp]

We recently upgraded our dependencies like follows:

    "@nomiclabs/hardhat-ethers": "^2.2.1",
    "@nomiclabs/hardhat-waffle": "^2.0.0",
    "@typechain/hardhat": "^6.1.4",

to

    "@nomiclabs/hardhat-ethers": "^2.2.2",
    "@nomiclabs/hardhat-waffle": "^2.0.5",
    "@typechain/hardhat": "^6.1.5",

We use custom errors extensively in our Solidity code. For example:

...
revert ICustomErrors.RequiresMarketplaceActiveMembership(params.governor);
...

Before, we were able to match this nicely in our tests, such as:

await expect(subject).to.be
  .revertedWith(`RequiresMarketplaceActiveMembership("${governor.address}")`);

This was particularly useful as some methods might revert with the same custom error (in this example RequiresMarketplaceActiveMembership but with different parameters, based on what went wrong), and we were able to be very thorough in our tests, making them very resilient and not just "coverage for the sake of it".

It seems that someone thought it could be a good idea to strip anything in parentheses of revert messages, so now we can only match such as:

await expect(subject).to.be
  .revertedWith('RequiresMarketplaceActiveMembership');

[yivlad]

If you're using hardhat you can check parameters using withArgs matcher.

Waffle/waffle-hardhat/test/reverted.test.ts

Lines 62 to 69 in 0915e72

	await expect(matchers.doRevertWithOne())
	.to.be.revertedWith('One')
	.withArgs(
	BigNumber.from('0'), // Check BigNumber instance as well.
	'message',
	'0x00cfbbaf7ddb3a1476767101c12a0162e241fbad2a0162e2410cfbbaf7162123'
	);
	});