New extension: Webhooks (TurboHook replacement)

[CubesterYT]

Hello all!

The time has finally come, the long awaited successor to the horrendous extension that is "TurboHook". Under code name "TurboHook V2", this extension took time to develop as I waited for certain APIs to happen (extension storage my beloved), and also just forgetting about the extension in the first place 😅. I deemed it smart to make this a whole new extension entirely, and TurboHook will now be hidden.

Video Example:

2025-01-16.23-49-59.mp4

Honestly, I'm going to consider this extension my Magnum Opus at the moment, since this represents my growth since I first contributed here. The difference between TurboHook and this extension is insane.

[SharkPool-SP]

seems good now

[yuri-kiss]

last change then im gonna review the docs

[GarboMuffin]

you need to await prompt() so that it works in the desktop app

ill read the rest of it later today

[CubesterYT]

you need to await prompt() so that it works in the desktop app

ill read the rest of it later today

OHHHH SO THAT'S WHY IT BROKE IN THE DESKTOP APP DURING MY TESTING

I'll get to fixing it

[GarboMuffin]

1. make a project with a webhook
2. save it
3. reload the page
4. load saved project
5. all the blocks are still hidden

[GarboMuffin]

dont like how empty try/catch is being used everywhere to handle errors

as it is right now a project can make a block that contains something like toString as the menu name and then store data on Object.prototype.toString.DATA and Object.prototype.toString.TYPE which probably doesn't break anything but it's definitely not great to do that. better to check if the webhook exists first

[GarboMuffin]

TurboHook still has functionality that this doesn't have, specifically the ability to send to arbitrary webhooks not known until runtime

[CubesterYT]

This is for sending webhooks, which is already possible, this is just a more elegant way

Do you want webhooks the other direction?

@GarboMuffin I think I mentioned this in passing a year ago during TurboHook, but I had an idea where we could have our own webhook system as well to allow users to make their own Webhooks and receive data. We could incorporate this with this extension.

[Brackets-Coder]

This is for sending webhooks, which is already possible, this is just a more elegant way

Do you want webhooks the other direction?

Yes, I'm aware it was already possible, I'm just remarking at how much better this extension is than TurboHook

I think webhooks in both directions would be fantastic

[GarboMuffin]

Using this pull request to test something with the bot !format

[github-actions]

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. To format all files, the pull request's author can manually run the 'Format pull request' workflow from the 'Actions' tab on the fork.

Dismissing old approvals so that moving forward everything follows #2327

[CubesterYT]

What's the status of this PR as of right now?

[SharkPool-SP]

You need to restart the review process cuz if the new rules

[SharkPool-SP]

• I verified that the extension follows all acceptance criteria and guidelines in CONTRIBUTING.md.
• I believe the block list is well-designed and intuitive.
• I tested all functionality and found no bugs, security flaws, or unintuitive behavior.
• I reviewed the code and believe it is well-written and easy to maintain or extend in the future, even without help from the original author.
• I have no additional concerns.

[CubesterYT]

!format

[Brackets-Coder]

I'll have to take a look tomorrow

[Brackets-Coder]

• I verified that the extension follows all acceptance criteria and guidelines in CONTRIBUTING.md.

• I believe the block list is well-designed and intuitive. - see note on hidden blocks, otherwise it's fine

• I tested all functionality and found no bugs, security flaws, or unintuitive behavior. - haven't tested this yet, this is a skim review

• I reviewed the code and believe it is well-written and easy to maintain or extend in the future, even without help from the original author.

• I have no additional concerns.

If you could clarify some of my confusion I'd appreciate it, thanks so much!

[CubesterYT]

@Brackets-Coder Have you even tried loading the extension into TurboWarp, lol?

• The extension storage data doesn't exist till runtime, so ignore the type check
• addWebhook isn't a block, it's a button. The entire palette is hidden unless you have a webhook added already. The button is meant for adding webhooks, etc. Think of it like the variables or lists categories.
• Thanks! I made the banner in inkscape.

[CubesterYT]

If anything, the video attached to this PR shows exactly how this works.

[Brackets-Coder]

I have in the past and I did just now, the review a few minutes ago was a quick skim

Sorry for the confusion about the hidden blocks

My concern about the security of sending user data still applies. Am I simply misunderstanding something again? Can the JSON parsing be exploited or is basically everything sanitized before posting? (Of course, most URLs would also have validation on their end...)

[CubesterYT]

This extension only sends data to the defined URLs. There is no security needing to be done on our part, because we're assuming the URLs that get data pushed through accept only the data that it needs (like usual)