Skip to content

Commit 6480a06

Browse files
fix(ui5-side-navigation): remove separator line (#11306)
fix(ui5-side-navigation): remove separator line from the hovered item in collapsed SideNavigation JIRA: BGSOFUIRODOPI-3443
1 parent 6827fdc commit 6480a06

File tree

6 files changed

+13
-20
lines changed

6 files changed

+13
-20
lines changed

packages/fiori/src/themes/SideNavigationItemBase.css

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@ and there is an additional border that appears on hover. */
197197
min-width: 3rem;
198198
}
199199

200-
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):hover .ui5-sn-item-toggle-icon,
201-
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus .ui5-sn-item-toggle-icon,
202200
:host(:not([side-nav-collapsed])) .ui5-sn-item-toggle-icon {
203201
min-width: var(--_ui5_side_navigation_expand_icon_width);
204202
padding-inline: 0.25rem 0.375rem;
@@ -209,11 +207,16 @@ and there is an additional border that appears on hover. */
209207

210208
:host([unselectable]:not([side-nav-collapsed])) .ui5-sn-item-toggle-icon,
211209
:host(:not([side-nav-collapsed])) .ui5-sn-item-group .ui5-sn-item-toggle-icon,
212-
:host([unselectable][side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):hover .ui5-sn-item-toggle-icon,
213-
:host([unselectable][side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus .ui5-sn-item-toggle-icon {
210+
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):hover .ui5-sn-item-toggle-icon,
211+
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus .ui5-sn-item-toggle-icon {
214212
border-inline-start: none;
215213
}
216214

215+
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):hover .ui5-sn-item-toggle-icon,
216+
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus .ui5-sn-item-toggle-icon {
217+
min-width: 3rem;
218+
}
219+
217220
:host([in-popover]) .ui5-sn-item-toggle-icon {
218221
display: none;
219222
}
@@ -254,19 +257,14 @@ and there is an additional border that appears on hover. */
254257
width: var(--_ui5_side_navigation_item_collapsed_hover_focus_width);
255258
box-shadow: var(--_ui5_side_navigation_box_shadow);
256259
z-index: 2;
257-
padding-inline-end: var(--_ui5_side_navigation_item_collapsed_padding_right);
260+
padding-inline-end: var(--_ui5_side_navigation_item_collapsed_padding);
258261
}
259262

260263
:host([side-nav-collapsed]) a.ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):hover:not(.ui5-sn-item-with-expander),
261264
:host([side-nav-collapsed]) a.ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus:not(.ui5-sn-item-with-expander) {
262265
padding-inline-end: 0;
263266
}
264267

265-
:host([unselectable][side-nav-collapsed]) .ui5-sn-item.ui5-sn-item.ui5-sn-item-with-expander:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):hover,
266-
:host([unselectable][side-nav-collapsed]) .ui5-sn-item.ui5-sn-item.ui5-sn-item-with-expander:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus {
267-
padding-inline-end: var(--_ui5_side_navigation_item_collapsed_unselectable_padding);
268-
}
269-
270268
:host([unselectable][side-nav-collapsed]) div.ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):not(.ui5-sn-item-with-expander):hover,
271269
:host([unselectable][side-nav-collapsed]) div.ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):not(.ui5-sn-item-with-expander):focus {
272270
padding-inline-end: var(--_ui5_side_navigation_action_item_collapsed_padding);

packages/fiori/src/themes/base/SideNavigation-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,8 @@
5959
--_ui5_side_navigation_item_collapsed_hover_focus_width: auto;
6060
--_ui5_side_navigation_item_collapsed_hover_focus_display: none;
6161
--_ui5_side_navigation_item_collapsed_hover_focus_padding_right: 0;
62-
--_ui5_side_navigation_item_collapsed_padding_right: 0;
6362
--_ui5_side_navigation_action_item_collapsed_padding: 0;
64-
--_ui5_side_navigation_item_collapsed_unselectable_padding: 0;
63+
--_ui5_side_navigation_item_collapsed_padding: 0;
6564
--_ui5_side_navigation_action_item_border_hover: var(--sapButton_BorderWidth) solid var(--sapButton_Hover_BorderColor);
6665
--_ui5_side_navigation_action_item_border_active: var(--sapButton_BorderWidth) solid var(--sapButton_Active_BorderColor);
6766

packages/fiori/src/themes/sap_horizon/SideNavigation-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,8 @@
4646
--_ui5_side_navigation_item_collapsed_hover_focus_width: fit-content;
4747
--_ui5_side_navigation_item_collapsed_hover_focus_display: block;
4848
--_ui5_side_navigation_item_collapsed_hover_focus_padding_right: 1rem;
49-
--_ui5_side_navigation_item_collapsed_padding_right: 3.9375rem;
5049
--_ui5_side_navigation_action_item_collapsed_padding: 1rem;
51-
--_ui5_side_navigation_item_collapsed_unselectable_padding: 3rem;
50+
--_ui5_side_navigation_item_collapsed_padding: 3rem;
5251
}
5352

5453
[data-ui5-compact-size],

packages/fiori/src/themes/sap_horizon_dark/SideNavigation-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,8 @@
4646
--_ui5_side_navigation_item_collapsed_hover_focus_width: fit-content;
4747
--_ui5_side_navigation_item_collapsed_hover_focus_display: block;
4848
--_ui5_side_navigation_item_collapsed_hover_focus_padding_right: 1rem;
49-
--_ui5_side_navigation_item_collapsed_padding_right: 3.9375rem;
5049
--_ui5_side_navigation_action_item_collapsed_padding: 1rem;
51-
--_ui5_side_navigation_item_collapsed_unselectable_padding: 3rem;
50+
--_ui5_side_navigation_item_collapsed_padding: 3rem;
5251
}
5352

5453
[data-ui5-compact-size],

packages/fiori/src/themes/sap_horizon_hcb/SideNavigation-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,8 @@
4343
--_ui5_side_navigation_item_collapsed_hover_focus_width: fit-content;
4444
--_ui5_side_navigation_item_collapsed_hover_focus_display: block;
4545
--_ui5_side_navigation_item_collapsed_hover_focus_padding_right: 1rem;
46-
--_ui5_side_navigation_item_collapsed_padding_right: 3.9375rem;
4746
--_ui5_side_navigation_action_item_collapsed_padding: 1rem;
48-
--_ui5_side_navigation_item_collapsed_unselectable_padding: 3rem;
47+
--_ui5_side_navigation_item_collapsed_padding: 3rem;
4948
}
5049

5150
[data-ui5-compact-size],

packages/fiori/src/themes/sap_horizon_hcw/SideNavigation-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,8 @@
4343
--_ui5_side_navigation_item_collapsed_hover_focus_width: fit-content;
4444
--_ui5_side_navigation_item_collapsed_hover_focus_display: block;
4545
--_ui5_side_navigation_item_collapsed_hover_focus_padding_right: 1rem;
46-
--_ui5_side_navigation_item_collapsed_padding_right: 3.9375rem;
4746
--_ui5_side_navigation_action_item_collapsed_padding: 1rem;
48-
--_ui5_side_navigation_item_collapsed_unselectable_padding: 3rem;
47+
--_ui5_side_navigation_item_collapsed_padding: 3rem;
4948
}
5049

5150
[data-ui5-compact-size],

0 commit comments

Comments
 (0)