Gamescope doesn't quit when game quits

[shindaseishin]

OS: KUbuntu 22.10
Kernels tested: stock ubuntu 5.19.0 and xanmod 6.1
GPU: AMD RX 570
Mesa version: 22.2.5

Tested on both Plasma X11 and Plasma Wayland.

When I play a game via steam using gamescope everything works correctly until I quit the game.

When I do, the game ends, music stops playing, etc. but I am not dropped out to desktop. Steam shows the game is still running. I can bring up the process manager and see that the game process is no longer running but an instance of gamescope will still be running. Killing it will make the game disappear and the desktop to return. I can also kill the gamescope process by pressing stop in the steam client. It happens both full screen and windowed.

I have tested with Pillars of Eternity: Deadfire (Linux native), Valheim (native), Aragami 2 (proton), and Portal (native). All exhibit the same behaviour.

I also tried Stardew Valley (with SMAPI installed) but that exited correctly. Not sure why that worked when the others did not.

Compiled git master branch (fully up to date as of about an hour ago).

Happy to provide any additional details if they would help.

[iggut]

Same here in Ubuntu 22.10 Gnome wayland.
Compiled it today and tried Looking-Glass-Client for my Windows 11 VM with gamescope and it works very well.
When shutting down windows it closes looking-glass, but the terminal that was used to launch gamescope/looking-glass needs a Ctrl+C to stop the process.

This is the last line in terminal where it waits for me to kill the process:
xwm: error 3: BadWindow (invalid Window parameter) request 15 minor 0 serial 270140

Not sure if it has anything to do with the issue, just though I'd add the info.

[patlefort]

A little debugging show that it is stuck on https://github.com/Plagman/gamescope/blob/2a09fbcb695102e9a990ed7cf1fdc350397a58f1/src/wlserver.cpp#L1211

Adding a timeout fix the issue, however I don't know why it is stuck there.

[Faugus]

I'm having this problem with Life is Strange: Before the Storm.
If I Alt+F4, Gamescope closes.
But if I quit the game from the main menu, Gamescope won't close.

A little debugging show that it is stuck on

https://github.com/Plagman/gamescope/blob/2a09fbcb695102e9a990ed7cf1fdc350397a58f1/src/wlserver.cpp#L1211

Adding a timeout fix the issue, however I don't know why it is stuck there.

How did you add this timeout?

[patlefort]

How did you add this timeout?

By changing -1 in that line to a value in milliseconds, like 1000.

[shindaseishin]

I tried adding the timeout as @patlefort suggested and it worked. Thank you!

[Faugus]

How did you add this timeout?

By changing -1 in that line to a value in milliseconds, like 1000.

Is there a way to add this timeout to a already compiled build? Cause I'm using the Gamescope from Arch's repository.

[shindaseishin]

No. That value is hard coded into the program and can't be changed at run time, only compile time. Maybe someone could make a pull request with the change in it to get it into the main code base which would get in to the arch version eventually, but it is probably better to figure out why the original line is failing.

[DocMAX]

Shouldn't gamescope -- sleep 3 close gamescope after 3 sec?

[shindaseishin]

Nope. It doesn't close after 3 seconds. I recompiled gamescope to current master without the fix @patlefort suggested and ran the command @DocMAX posted. With the process monitor open I can see gamescope start and then a moment later sleep starts. Three seconds later sleep quits but gamescope keeps going. I have to manually kill it.

Just for testing purposes, I reran a few games with the recompiled version, Valheim still exhibits the issue, but Cyberpunk 2077 does not.

[DocMAX]

So is this a bug or not?

[shindaseishin]

It is a bug. gamescope doesn't quit. It stays resident in memory after it is supposed to have ended and continues to display a screen when it is not supposed to.

[mlgomez]

A little debugging show that it is stuck on

https://github.com/Plagman/gamescope/blob/2a09fbcb695102e9a990ed7cf1fdc350397a58f1/src/wlserver.cpp#L1211

Adding a timeout fix the issue, however I don't know why it is stuck there.

This seems like something that should be in a pull request.

[awsms]

I noticed that killing gamescope won't kill the invoked program either.... is it expected behaviour, or another bug?

[EoceneMiacid]

This is really quite a severe bug.

It means I can start a Steam game in gamescope just fine, but I can't launch another one without rebooting the PC, even after explicitly killing the 'gamescope' process, restarting Steam, etc.

If I exit a non-Steam game in gamescope, the process won't terminate properly either. After a while, the console it was started from starts spamming the message 'vblankmanager: write failed: Resource temporarily unavailable'.