Skip to content

Conversation

@eukarpov
Copy link
Member

No description provided.

@eukarpov eukarpov force-pushed the disable-artifact-upload-by-default branch from 5dea2db to f9483db Compare January 18, 2025 17:22
@Blackhex
Copy link
Member

The errors with missing cache entires we are seeing are caused by the fact that several conditions needs to be met to allow transwer of cache packages accross different runners (see https://github.com/actions/cache?tab=readme-ov-file#cache-version):

I have myself issues to make it working withing this PR #241

- name: Upload build folder
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && failure() }}
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && env.UPLOAD_ARTIFACTS == 'true' && failure() }}
Copy link
Member

@Blackhex Blackhex Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build folder is uploaded for the reason of debugging when build fails. This should not happen that frequently. If its size is still a problem remove the step entirely as with default false is not usefull at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful when UPLOAD_ARTIFACTS is true and it can be used for debugging.

Copy link
Member

@Blackhex Blackhex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks acceptable when the caching issues will be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants