Improve INSERT and UPDATE error handling

Author: JanJakes

tests/WP_SQLite_Driver_Tests.php

@@ -11068,4 +11068,70 @@ public function testCastValuesOnUpdateInNonStrictMode(): void {
 
 		$this->assertQuery( 'DROP TABLE t' );
 	}
+
+	public function testInsertErrors(): void {
+		$this->assertQuery( 'CREATE TABLE t (value INT)' );
+
+		// Missing table.
+		$this->assertQueryError(
+			'INSERT INTO missing_table VALUES (1)',
+			"SQLSTATE[42S02]: Base table or view not found: 1146 Table 'missing_table' doesn't exists"
+		);
+
+		// Missing column.
+		$this->assertQueryError(
+			'INSERT INTO t (missing_column) VALUES (1)',
+			"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'missing_column' in 'field list'"
+		);
+	}
+
+	public function testInsertErrorsInNonStrictMode(): void {
+		$this->assertQuery( "SET SESSION sql_mode = ''" );
+		$this->assertQuery( 'CREATE TABLE t (value INT)' );
+
+		// Missing table.
+		$this->assertQueryError(
+			'INSERT INTO missing_table VALUES (1)',
+			"SQLSTATE[42S02]: Base table or view not found: 1146 Table 'missing_table' doesn't exists"
+		);
+
+		// Missing column.
+		$this->assertQueryError(
+			'INSERT INTO t (missing_column) VALUES (1)',
+			"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'missing_column' in 'field list'"
+		);
+	}
+
+	public function testUpdateErrors(): void {
+		$this->assertQuery( 'CREATE TABLE t (value INT)' );
+
+		// Missing table.
+		$this->assertQueryError(
+			'UPDATE missing_table SET value = 1',
+			"SQLSTATE[42S02]: Base table or view not found: 1146 Table 'missing_table' doesn't exists"
+		);
+
+		// Missing column.
+		$this->assertQueryError(
+			'UPDATE t SET missing_column = 1',
+			"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'missing_column' in 'field list'"
+		);
+	}
+
+	public function testUpdateErrorsInNonStrictMode(): void {
+		$this->assertQuery( "SET SESSION sql_mode = ''" );
+		$this->assertQuery( 'CREATE TABLE t (value INT)' );
+
+		// Missing table.
+		$this->assertQueryError(
+			'UPDATE missing_table SET value = 1',
+			"SQLSTATE[42S02]: Base table or view not found: 1146 Table 'missing_table' doesn't exists"
+		);
+
+		// Missing column.
+		$this->assertQueryError(
+			'UPDATE t SET missing_column = 1',
+			"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'missing_column' in 'field list'"
+		);
+	}
 }

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -4417,6 +4417,17 @@ private function translate_insert_or_replace_body(
 			array( $database, $table_name )
 		)->fetchAll( PDO::FETCH_ASSOC );
 
+		// Check if the table exists.
+		if ( 0 === count( $columns ) ) {
+			throw $this->new_driver_exception(
+				sprintf(
+					"SQLSTATE[42S02]: Base table or view not found: 1146 Table '%s' doesn't exists",
+					$table_name
+				),
+				'42S02'
+			);
+		}
+
 		// Get a list of columns that are targeted by the INSERT or REPLACE query.
 		// This is either an explicit column list, or all columns of the table.
 		$insert_list = array();
@@ -4442,6 +4453,18 @@ private function translate_insert_or_replace_body(
 			}
 		}
 
+		// Check if all listed columns exist.
+		$unkwnown_columns = array_diff( $insert_list, array_column( $columns, 'COLUMN_NAME' ) );
+		if ( count( $unkwnown_columns ) > 0 ) {
+			throw $this->new_driver_exception(
+				sprintf(
+					"SQLSTATE[42S22]: Column not found: 1054 Unknown column '%s' in 'field list'",
+					$unkwnown_columns[0]
+				),
+				'42S22'
+			);
+		}
+
 		// Prepare a helper map of columns that are included in the INSERT list.
 		$insert_map = array_combine( $insert_list, $insert_list );
 
@@ -4617,7 +4640,19 @@ private function translate_update_list( string $table_name, WP_Parser_Node $node
 			',
 			array( $database, $table_name )
 		)->fetchAll( PDO::FETCH_ASSOC );
-		$column_map    = array_combine( array_column( $columns, 'COLUMN_NAME' ), $columns );
+
+		// Check if the table exists.
+		if ( 0 === count( $columns ) ) {
+			throw $this->new_driver_exception(
+				sprintf(
+					"SQLSTATE[42S02]: Base table or view not found: 1146 Table '%s' doesn't exists",
+					$table_name
+				),
+				'42S02'
+			);
+		}
+
+		$column_map = array_combine( array_column( $columns, 'COLUMN_NAME' ), $columns );
 
 		// Translate the UPDATE list, emulating IMPLICIT DEFAULTs for NULL values.
 		$fragment = '';
@@ -4628,7 +4663,17 @@ private function translate_update_list( string $table_name, WP_Parser_Node $node
 
 			// Get column info.
 			$column_name = $this->unquote_sqlite_identifier( $this->translate( end( $column_ref_parts ) ) );
-			$column_info = $column_map[ strtolower( $column_name ) ];
+			$column_info = $column_map[ strtolower( $column_name ) ] ?? null;
+			if ( ! $column_info ) {
+				throw $this->new_driver_exception(
+					sprintf(
+						"SQLSTATE[42S22]: Column not found: 1054 Unknown column '%s' in 'field list'",
+						$column_name
+					),
+					'42S22'
+				);
+			}
+
 			$data_type   = $column_info['DATA_TYPE'];
 			$is_nullable = 'YES' === $column_info['IS_NULLABLE'];
 			$default     = $column_info['COLUMN_DEFAULT'];