Skip to content

Conversation

@johnbillion
Copy link
Member

@johnbillion johnbillion commented Sep 4, 2025

This temporarily disables failing Imagick tests prior to investigation.

Adds some missing WP_Error assertions too which means an error will be a failure instead.

Branches from #9746

Trac ticket: https://core.trac.wordpress.org/ticket/63932
Trac ticket: https://core.trac.wordpress.org/ticket/63876

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@johnbillion johnbillion marked this pull request as ready for review September 4, 2025 22:42
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, siliconforks, desrosj, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, but looks good overall!

*
* // Temporarily disabled until we can figure out why it fails on the Trixie based PHP container.
* // See https://core.trac.wordpress.org/ticket/63932.
* @requires PHP < 8.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that this will eventually need to be changed to PHP < 8.1 should a security update be released for 8.1 & 8.2.

I think referencing the ticket is OK for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to do this in the test where we can check the imagemagick version using Imagick::getVersion()? I don't have a strong opinion but it should make the concern about future containers go away

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suggested over in #9775

@johnbillion
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants