Sometimes one menu entry icon is missing when theme used with no desktop-image defined

[steve6375]

There seems to be a bug in the theme code. Please see...
https://rmprepusb.blogspot.com/2020/05/new-large-font-theme-for-agfm-and.html
[seven14LargeFont_theme.zip]
Note the missing icon (second menu entry). The icon appears as soon as you move the cursor down/up.
(https://github.com/a1ive/grub/files/4621302/seven14LargeFont_theme.zip)

[steve6375]

Repro the bug...
If you want to test the missing icon bug for yourself, just comment out the desktop-image entry in the fm.txt menu file as shown below and then navigate to a folder which has a lot of entries - often one of them will be missing!:

# Global Property
title-color: "#ffffff"
title-text: "Easy2Boot agFM"
message-color: "#FFFFFF"
message-bg-color: "#000000"
desktop-color: "#000000"
#desktop-image: "black.jpeg"
terminal-box: "term_bkg_*.png"
desktop-image-scale-method: "stretch"

[a1ive]

before:

after:

But I still can't figure out why this solves the problem. I don't think this NULL pointer check is needed.

[steve6375]

top left corner of grey background is also missing. I noticed that too in my tests.

[a1ive]

have you tried the latest grub2 build?

[steve6375]

Seems to have fixed it! I tried a few different themes. :-)

[a1ive]

Does the official gnu grub also have this bug?

[steve6375]

I don't know. I tried Googling for any similar issue but couldn't find anything.

[a1ive]

it still happens randomly!