Skip to content

Commit 956d620

Browse files
committed
Updated UpdaterAndFilterEngineCreationTest to match coding convention
1 parent 1ae9556 commit 956d620

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

test/UpdaterAndFilterEngineCreation.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ TEST_F(UpdaterAndFilterEngineCreationTest, TestFilterEngineSingleInstance)
100100
{
101101
CallGetFilterEngineSimultaneously();
102102
FilterEngine* filterEngineAddr = filterAddrArray[0];
103-
ASSERT_NE(filterEngineAddr, nullptr);
103+
EXPECT_NE(nullptr, filterEngineAddr);
104104
for (size_t i = 1; i < COUNT; ++i)
105105
ASSERT_EQ(filterEngineAddr, filterAddrArray[i]);
106106
}
@@ -109,18 +109,18 @@ TEST_F(UpdaterAndFilterEngineCreationTest, TestUpdaterSingleInstance)
109109
{
110110
CallGetUpdaterSimultaneously();
111111
Updater* updaterAddr = updaterAddrArray[0];
112-
ASSERT_NE(updaterAddr, nullptr);
112+
EXPECT_NE(nullptr, updaterAddr);
113113
for (size_t i = 1; i < COUNT; ++i)
114114
ASSERT_EQ(updaterAddr, updaterAddrArray[i]);
115115
}
116116

117117
TEST_F(UpdaterAndFilterEngineCreationTest, TestUpdaterAndFilterEngineCreationsDontCollide)
118118
{
119119
CallGetUpdaterAndGetFilterEngineSimultaneously();
120-
ASSERT_NE(filterAddrArray[0], nullptr);
121-
ASSERT_EQ(filterAddrArray[0], filterAddrArray[COUNT - 1]);
122-
ASSERT_NE(updaterAddrArray[0], nullptr);
123-
ASSERT_EQ(updaterAddrArray[0], updaterAddrArray[COUNT - 1]);
120+
EXPECT_NE(nullptr, filterAddrArray[0]);
121+
EXPECT_NE(nullptr, updaterAddrArray[0]);
122+
EXPECT_EQ(filterAddrArray[0], filterAddrArray[COUNT - 1]);
123+
EXPECT_EQ(updaterAddrArray[0], updaterAddrArray[COUNT - 1]);
124124
}
125125

126126
TEST_F(UpdaterAndFilterEngineCreationTest, TestUpdaterAndFilterEngineCreationOrder1)
@@ -130,14 +130,14 @@ TEST_F(UpdaterAndFilterEngineCreationTest, TestUpdaterAndFilterEngineCreationOrd
130130

131131
int propFromUpdater = updater.GetPref(PROP_NAME).AsInt();
132132
int propFromFilterEngine = filterEngine.GetPref(PROP_NAME).AsInt();
133-
ASSERT_EQ(propFromUpdater, propFromFilterEngine);
133+
EXPECT_EQ(propFromUpdater, propFromFilterEngine);
134134

135135
int newPropValue = 8;
136136
updater.SetPref(PROP_NAME, GetJsEngine().NewValue(newPropValue));
137137
propFromUpdater = updater.GetPref(PROP_NAME).AsInt();
138138
propFromFilterEngine = filterEngine.GetPref(PROP_NAME).AsInt();
139-
ASSERT_EQ(propFromUpdater, newPropValue);
140-
ASSERT_EQ(propFromFilterEngine, newPropValue);
139+
EXPECT_EQ(newPropValue, propFromUpdater);
140+
EXPECT_EQ(newPropValue, propFromFilterEngine);
141141
}
142142

143143
TEST_F(UpdaterAndFilterEngineCreationTest, TestUpdaterAndFilterEngineCreationOrder2)
@@ -147,12 +147,12 @@ TEST_F(UpdaterAndFilterEngineCreationTest, TestUpdaterAndFilterEngineCreationOrd
147147

148148
int propFromFilterEngine = filterEngine.GetPref(PROP_NAME).AsInt();
149149
int propFromUpdater = updater.GetPref(PROP_NAME).AsInt();
150-
ASSERT_EQ(propFromUpdater, propFromFilterEngine);
150+
EXPECT_EQ(propFromUpdater, propFromFilterEngine);
151151

152152
int newPropValue = 18;
153153
filterEngine.SetPref(PROP_NAME, GetJsEngine().NewValue(newPropValue));
154154
propFromFilterEngine = filterEngine.GetPref(PROP_NAME).AsInt();
155155
propFromUpdater = updater.GetPref(PROP_NAME).AsInt();
156-
ASSERT_EQ(propFromUpdater, newPropValue);
157-
ASSERT_EQ(propFromFilterEngine, newPropValue);
156+
EXPECT_EQ(newPropValue, propFromUpdater);
157+
EXPECT_EQ(newPropValue, propFromFilterEngine);
158158
}

0 commit comments

Comments
 (0)