fix: add proper guards around callbacks and handling of invalid values

Author: uerceg

android/src/main/java/com/adjust/sdk/Adjust.java

@@ -603,9 +603,15 @@ public void processDeeplink(final ReadableMap mapDeeplink) {
     @ReactMethod
     public void processAndResolveDeeplink(final ReadableMap mapDeeplink, final Callback callback) {
         if (mapDeeplink == null) {
+            if (callback != null) {
+                callback.invoke((String) null);
+            }
             return;
         }
         if (!checkKey(mapDeeplink, "deeplink")) {
+            if (callback != null) {
+                callback.invoke((String) null);
+            }
             return;
         }
 
@@ -622,7 +628,9 @@ public void processAndResolveDeeplink(final ReadableMap mapDeeplink, final Callb
             new OnDeeplinkResolvedListener() {
             @Override
             public void onDeeplinkResolved(String resolvedLink) {
-                callback.invoke(resolvedLink);
+                if (callback != null) {
+                    callback.invoke(resolvedLink);
+                }
             }
         });
     }
@@ -631,7 +639,7 @@ public void onDeeplinkResolved(String resolvedLink) {
     public void resolveLinkWithUrl(final String url, final ReadableArray resolveUrlSuffixArray, final Callback callback) {
         if (url == null) {
             if (callback != null) {
-                callback.invoke("");
+                callback.invoke((String) null);
             }
             return;
         }
@@ -649,8 +657,10 @@ public void resolveLinkWithUrl(final String url, final ReadableArray resolveUrlS
             new com.adjust.sdk.AdjustLinkResolution.AdjustLinkResolutionCallback() {
                 @Override
                 public void resolvedLinkCallback(Uri resolvedLink) {
-                    String resolvedUrl = resolvedLink != null ? resolvedLink.toString() : "";
-                    callback.invoke(resolvedUrl);
+                    if (callback != null) {
+                        String resolvedUrl = resolvedLink != null ? resolvedLink.toString() : null;
+                        callback.invoke(resolvedUrl);
+                    }
                 }
             }
         );
@@ -743,7 +753,9 @@ public void isEnabled(final Callback callback) {
             new com.adjust.sdk.OnIsEnabledListener() {
             @Override
             public void onIsEnabledRead(boolean isEnabled) {
-                callback.invoke(isEnabled);
+                if (callback != null) {
+                    callback.invoke(isEnabled);
+                }
             }
         });
     }
@@ -753,7 +765,9 @@ public void getAttribution(final Callback callback) {
         com.adjust.sdk.Adjust.getAttribution(new com.adjust.sdk.OnAttributionReadListener() {
             @Override
             public void onAttributionRead(AdjustAttribution attribution) {
-                callback.invoke(AdjustUtil.attributionToMap(attribution));
+                if (callback != null) {
+                    callback.invoke(AdjustUtil.attributionToMap(attribution));
+                }
             }
         });
     }
@@ -763,7 +777,9 @@ public void getAdid(final Callback callback) {
         com.adjust.sdk.Adjust.getAdid(new com.adjust.sdk.OnAdidReadListener() {
             @Override
             public void onAdidRead(String adid) {
-                callback.invoke(adid);
+                if (callback != null) {
+                    callback.invoke(adid != null ? adid : null);
+                }
             }
         });
     }
@@ -775,8 +791,10 @@ public void getLastDeeplink(final Callback callback) {
             new OnLastDeeplinkReadListener() {
             @Override
             public void onLastDeeplinkRead(Uri uri) {
-                String strUri = (uri != null) ? uri.toString() : "";
-                callback.invoke(strUri);
+                if (callback != null) {
+                    String strUri = (uri != null) ? uri.toString() : null;
+                    callback.invoke(strUri);
+                }
             }
         });
     }
@@ -786,10 +804,12 @@ public void getSdkVersion(final String sdkPrefix, final Callback callback) {
         com.adjust.sdk.Adjust.getSdkVersion(new com.adjust.sdk.OnSdkVersionReadListener() {
             @Override
             public void onSdkVersionRead(String sdkVersion) {
-                if (sdkVersion == null) {
-                    callback.invoke("");
-                } else {
-                    callback.invoke(sdkPrefix + "@" + sdkVersion);
+                if (callback != null) {
+                    if (sdkVersion == null) {
+                        callback.invoke((String) null);
+                    } else {
+                        callback.invoke(sdkPrefix + "@" + sdkVersion);
+                    }
                 }
             }
         });
@@ -918,6 +938,10 @@ public void trackPlayStoreSubscription(final ReadableMap mapEvent) {
     @ReactMethod
     public void verifyPlayStorePurchase(final ReadableMap mapEvent, final Callback callback) {
         if (mapEvent == null) {
+            if (callback != null) {
+                WritableMap map = Arguments.createMap();
+                callback.invoke(map);
+            }
             return;
         }
 
@@ -963,6 +987,10 @@ public void onVerificationFinished(AdjustPurchaseVerificationResult verification
     @ReactMethod
     public void verifyAndTrackPlayStorePurchase(final ReadableMap mapEvent, final Callback callback) {
         if (mapEvent == null) {
+            if (callback != null) {
+                WritableMap map = Arguments.createMap();
+                callback.invoke(map);
+            }
             return;
         }
 
@@ -1097,7 +1125,9 @@ public void getGoogleAdId(final Callback callback) {
             new com.adjust.sdk.OnGoogleAdIdReadListener() {
             @Override
             public void onGoogleAdIdRead(String googleAdId) {
-                callback.invoke(googleAdId);
+                if (callback != null) {
+                    callback.invoke(googleAdId);
+                }
             }
         });
     }
@@ -1109,7 +1139,9 @@ public void getAmazonAdId(final Callback callback) {
             new com.adjust.sdk.OnAmazonAdIdReadListener() {
             @Override
             public void onAmazonAdIdRead(String amazonAdId) {
-                callback.invoke(amazonAdId);
+                if (callback != null) {
+                    callback.invoke(amazonAdId);
+                }
             }
         });
     }

index.d.ts

@@ -227,22 +227,22 @@ declare module 'react-native-adjust' {
     getIdfa: (callback: (idfa: string | null) => void) => void
     getIdfv: (callback: (idfv: string | null) => void) => void
     getGoogleAdId: (callback: (adid: string | null) => void) => void
-    getAdid: (callback: (adid: string) => void) => void
+    getAdid: (callback: (adid: string | null) => void) => void
     getAttribution: (callback: (attribution: AdjustAttribution) => void) => void
     getAmazonAdId: (callback: (adid: string | null) => void) => void
-    getSdkVersion: (callback: (sdkVersion: string) => void) => void
+    getSdkVersion: (callback: (sdkVersion: string | null) => void) => void
     requestAppTrackingAuthorization: (handler: (status: number) => void) => void
     updateSkanConversionValue: (conversionValue: number, coarseValue: string, lockWindow: boolean, callback: (error: string | null) => void) => void
     getAppTrackingAuthorizationStatus: (callback: (status: number) => void) => void
     trackThirdPartySharing: (adjustThirdPartySharing: AdjustThirdPartySharing) => void
     trackMeasurementConsent: (measurementConsent: boolean) => void
-    getLastDeeplink: (callback: (lastDeeplink: string) => void) => void
+    getLastDeeplink: (callback: (lastDeeplink: string | null) => void) => void
     verifyAppStorePurchase: (purchase: AdjustAppStorePurchase, callback: (verificationResult: AdjustPurchaseVerificationResult) => void) => void
     verifyAndTrackAppStorePurchase: (adjustEvent: AdjustEvent, callback: (verificationResult: AdjustPurchaseVerificationResult) => void) => void
     verifyPlayStorePurchase: (purchase: AdjustPlayStorePurchase, callback: (verificationResult: AdjustPurchaseVerificationResult) => void) => void
     verifyAndTrackPlayStorePurchase: (adjustEvent: AdjustEvent, callback: (verificationResult: AdjustPurchaseVerificationResult) => void) => void
-    processAndResolveDeeplink: (adjustDeeplink: AdjustDeeplink, callback: (resolvedLink: string) => void) => void
-    resolveLinkWithUrl: (url: string, resolveUrlSuffixArray: string[], callback: (resolvedLink: string) => void) => void
+    processAndResolveDeeplink: (adjustDeeplink: AdjustDeeplink, callback: (resolvedLink: string | null) => void) => void
+    resolveLinkWithUrl: (url: string, resolveUrlSuffixArray: string[], callback: (resolvedLink: string | null) => void) => void
     endFirstSessionDelay: () => void
     enableCoppaComplianceInDelay: () => void
     disableCoppaComplianceInDelay: () => void