Skip to content

fix: close onboarding site form after onboard button clicked #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: close onboarding site form after onboard button clicked #1354

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4616584
close onboarding site form after obutton clicked
tkotthakota-adobe Oct 13, 2025
b2658fc
Merge branch 'main' into SITES-36127
rpapani Oct 16, 2025
d0785a7
Merge branch 'main' of github.com:adobe/spacecat-api-service into SIT…
tkotthakota-adobe Oct 16, 2025
85f2788
Merge branch 'SITES-36127' of github.com:adobe/spacecat-api-service i…
tkotthakota-adobe Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/support/slack/actions/onboard-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,11 @@ export function onboardSiteModal(lambdaContext) {
}
}

await ack();

// Load configuration before ack() to avoid delays
const configuration = await Configuration.findLatest();

// Acknowledge immediately to close the modal
await ack();
const additionalParams = {};
if (deliveryType && deliveryType !== 'auto') {
additionalParams.deliveryType = deliveryType;
Expand Down