lingo link transformation #5164

vhargrave · 2025-11-26T19:11:20Z

This PR adds functionality for language-based link localisation for project lingo. The first project that will be consuming this is da-bacom and in order to unblock other teams this will hopefully be merged before the 9th December.
Due to the recent code freezes, this PR also contains the code of this other base PR - #5096

I've created diagrams explaining the flow of the link localization logic more here - https://wiki.corp.adobe.com/display/WP4/Project+Lingo+Link+Localization

When going through the pull request you'll see that localizeLink and decorateLinks are being made async. This was not a decision that was made lightly, but seemed to be the cleanest long term solution for link localization. For example, when localizeLink or decorateLinks are called, especially in other projects like cc, it is important that these functions always returns the same result if they are given the same input. Because query indexes can now play a major role in how links are localized, when a call to localizeLink is made, these query indexes must sometimes be awaited.
localizeLink and decorateLinks are being used in other projects and will need to be updated there after this PR. The blast damage is the following (usually one or max two usages per project)

List of projects to update
localizeLink:

Da-marketo
Unity
Cc-sandbox
Exchange-partners
Dme-partners
Cc
Genuine
Da-dx-partners

decorateLinks:

Cc
Dme-partners
Da-dx-partners
Express-milo

In addition, because these methods have been made async, and it meant touching the following features, if your site has one or more of them, especially on high traffic pages or in a special constellation, it would be to test them:

caas
faas
email-collection
marketo
global navigation (gnav & footer)
fragments / personalization

Resolves: MWPW-179494

Test URLs:

Milo

To help test this in a simulated prod env, I've added some overrides to the config for CC and Bacom, which is what the projects themselves would usually need to do. To use these overrides, just add -test to the branch link name in the URL like you see below

CC

Steps to test:

Scroll down to the accordion
Open first collapsible element - the link should be regionalized because it's in the preview query index https://main--cc--adobecom.aem.page/ch_de/cc-shared/assets/lingo/query-index-preview.json
Open fifth collapsible element - the link should also be regionalized
Go down to the footer
Second column, business.adobe.com link personalization at scale should be localized to /ch_de/
All other links in that column should point to /de

Steps to test:

Everything should be /de

DA-BACOM

Steps to test:

- Scroll down to the first bricks
- One on right should be regionaled to /ar for both .page & .live
- One in middle should be regionalized to /ar only for .page. On .live it should be /es because there is no entry of the page in the previewed query index and it should therefore default to /es.
- The brick on the left should always point to /es
- Scroll down to the footer.
- Look at the third column of links.
- The express link should get turned into /es
- The Creative cloud link should get turned into /ar
- The Illustrator link should get turned into /es

Steps to test:

Everything should be /es

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-sticky?martech=off&milolibs=vhargrave/lingo-link-transformation--milo--adobecom

Inline Branch Banner:

URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-inline?martech=off&milolibs=vhargrave/lingo-link-transformation--milo--adobecom

Blog

URL: https://main--blog--adobecom.aem.page/?martech=off&milolibs=vhargrave/lingo-link-transformation--milo--adobecom

RTL Locale

URL: https://main--homepage--adobecom.aem.live/mena_ar/homepage/index-loggedout?martech=off&milolibs=vhargrave/lingo-link-transformation--milo--adobecom

…obust

… minor fixes

aem-code-sync · 2025-11-26T19:11:23Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-sync branch

Commits

4455c40 ✅ (latest)
5d9d062 ✅
1bb98c4 ✅
90be857 ✅
2108a60 ✅
6ae1fa7 ✅
d0b071f ✅
593eae6 ✅
a38eca1 ✅
b5528e7 ✅
1b5c1ce ✅
289ffac ✅
8aeba71 ✅
db4960a ✅
79ae411 ✅
ddaedd8 ✅
115f15c ✅
0d953b1 ✅
3bbe482 ✅
6b4ef75 ✅
88de18d ❌
41ac25a ❌
0189e06 ❌
60d1517 ❌
8b3bb3c ❌
babc24c ❌
19cc391 ❌
a76eaca ❌
20a1818 ❌
67d7632 ❌

libs/blocks/faas-config/faas-config.js

libs/blocks/footer/footer.js

libs/blocks/merch/merch.js

sigadamvenkata · 2025-12-03T10:29:24Z

Hi @vhargrave , we can see the 'query-index' XSL files are previewed and published. so once the code goes to stage & prod will the feature enables? so we have any mechanism to turn feature on or off?

@sunilkamat @spadmasa

vhargrave · 2025-12-03T15:06:23Z

Hi @vhargrave , we can see the 'query-index' XSL files are previewed and published. so once the code goes to stage & prod will the feature enables? so we have any mechanism to turn feature on or off?

@sunilkamat @spadmasa

Hey @sigadamvenkata - yes, the link localization feature is an opt in and turned on over the metadata lingo . What is not opt in though because it shouldn't be breaking anything is that localizeLink and decorateLinks are now renamed and async. This shouldn't , but could have an impact on the following features:

caas
faas
email-collection
marketo
global navigation (gnav & footer)
fragments / personalization

so I'm grateful for any testing of these features using my code.

@sunilkamat @spadmasa

NadiiaSokolova

Verified. Ready for Stage.
Testing details MWPW-179494

sukamat · 2025-12-03T15:59:57Z

@spadmasa @sigadamvenkata For testing, @vhargrave has setup a manual query-index excel sheet in /ch_de/cc-shared/assets/lingo/query-index-preview just so that you guys can see that behavior. What is more important is that the existing functionality in ACOM is not broken. So other than validating the new feature in the test page that Victor provided, it is important to also make sure that ACOM continues to work as before by using other pages with Victor's branch. This link transformation feature will only apply to BACOM when it goes live in Feb (along with many other Lingo specific features) and will eventually be used on ACOM mid-next year. Hope that provides additional context.

cc: @nateekar

zagi25

email-collection block works as expected, on /de page /de resources are fetched

skumar09 · 2025-12-04T19:53:20Z

@team: I’ve added the do-not-merge label. I’ll remove it once we have QA sign-off from all the impacted projects/tracks. Testing is currently in progress.
cc: @vhargrave , @narcis-radu , @sunilkamat

# Conflicts: # libs/utils/utils.js

afmicka

looks good from the merch (M@S) side. Signing off MWPW-184759
cc: @skumar09

Brandon32

The marketo block works as expected.

sukamat · 2025-12-07T23:29:40Z

@vhargrave I had mentioned this in Slack but adding it here as well. CaaS is using a metadata flag langFirst for Lingo. They had set it up back in June when Newsroom went live as a language-first site. You can see the usage in the Newsroom metadata.xml file. Could we re-use the same flag? I cannot think of a use-case to keep them separate but LMK.

vhargrave · 2025-12-08T08:32:23Z

@vhargrave I had mentioned this in Slack but adding it here as well. CaaS is using a metadata flag langFirst for Lingo. They had set it up back in June when Newsroom went live as a language-first site. You can see the usage in the Newsroom metadata.xml file. Could we re-use the same flag? I cannot think of a use-case to keep them separate but LMK.

@sunilkamat I think we can - if we notice it's a mistake later on, this is something we can quickly pivot on. I've changed it 👍

sigadamvenkata · 2025-12-08T15:36:28Z

we are good from CC, FEDS, Unity, News.adobe.com tracks and can to STAGE.

Ruchika4 · 2025-12-08T17:13:45Z

Hi @vhargrave , for https://main--dc--adobecom.aem.page/ch_de/acrobat?milolibs=vhargrave-lingo-link-transformation-test&georouting=off&martech=off I see that links in footer that should point to /de/ as per PR description are also pointing to /ch_de/ Could you please help check.

vhargrave · 2025-12-08T17:46:36Z

Hi @vhargrave , for https://main--dc--adobecom.aem.page/ch_de/acrobat?milolibs=vhargrave-lingo-link-transformation-test&georouting=off&martech=off I see that links in footer that should point to /de/ as per PR description are also pointing to /ch_de/ Could you please help check.

Just had a call with @Ruchika4 to answer this. The code is working correctly since lingo is not active on dc.

overmyheadandbody and others added 22 commits November 6, 2025 15:09

Lingo locale config base

67d7632

Move to the new Lingo locale definition

20a1818

MWPW-181893 minor code refactoring

a76eaca

Merge branch 'stage' into lingo-base

19cc391

MWPW-181893 remove comment

babc24c

MWPW-181893 fix unit test

8b3bb3c

MWPW-181893 fix nala test language selector & make getLanguage more r…

60d1517

…obust

MWPW-181893 wait for placeholders to resolve

0189e06

MWPW-181893 make code more readable (PR feedback)

41ac25a

Merge branch 'stage' into lingo-base

88de18d

Merge branch 'stage' into vhargrave/lingo-link-transformation

6b4ef75

MWPW-179494 start adding query-index

3bbe482

MWPW-179494 start loading query indexes

0d953b1

MWPW-179494 ensure only one call for query indexes

115f15c

MWPW-179494 add async localize Link method

ddaedd8

MWPW-179494 add base implementation to localize links

79ae411

MWPW-179494 refactor slightly

db4960a

MWPW-179494 minor code fixes and add elements for testing

8aeba71

MWPW-179494 update decorateLinks to now be decorateLinksAsync and add…

289ffac

… minor fixes

MWPW-179494 use localizeLinkAsync

1b5c1ce

MWPW-179494 fix unit tests

b5528e7

MWPW-179494 refactor code

a38eca1

vhargrave added do not merge PR should not be merged yet high-impact Any PR that may affect consumers high priority Why is this a high priority? Blocker? Critical? Dependency? labels Nov 26, 2025

github-actions bot reviewed Nov 26, 2025

View reviewed changes

libs/blocks/faas-config/faas-config.js Show resolved Hide resolved

github-actions bot reviewed Nov 26, 2025

View reviewed changes

libs/blocks/faas-config/faas-config.js Show resolved Hide resolved

github-actions bot reviewed Nov 26, 2025

View reviewed changes

libs/blocks/faas-config/faas-config.js Show resolved Hide resolved

github-actions bot reviewed Nov 26, 2025

View reviewed changes

libs/blocks/footer/footer.js Show resolved Hide resolved

MWPW-179494 add metadata and url param switch for lingo

1832e7d

github-actions bot reviewed Dec 3, 2025

View reviewed changes

libs/blocks/merch/merch.js Show resolved Hide resolved

MWPW-179494 update unit tests

0af13d6

NadiiaSokolova self-assigned this Dec 3, 2025

NadiiaSokolova approved these changes Dec 3, 2025

View reviewed changes

NadiiaSokolova added Ready for Stage and removed Ready for Stage labels Dec 3, 2025

zagi25 approved these changes Dec 3, 2025

View reviewed changes

skumar09 added the do not merge PR should not be merged yet label Dec 4, 2025

Merge branch 'stage' into vhargrave/lingo-link-transformation

1709771

# Conflicts: # libs/utils/utils.js

afmicka approved these changes Dec 5, 2025

View reviewed changes

Brandon32 approved these changes Dec 5, 2025

View reviewed changes

sukamat approved these changes Dec 5, 2025

View reviewed changes

Roycethan approved these changes Dec 5, 2025

View reviewed changes

use langFirst metadata

d50dc04

vhargrave added 2 commits December 8, 2025 10:11

Merge branch 'stage' into vhargrave/lingo-link-transformation

27ff87e

Merge branch 'stage' into vhargrave/lingo-link-transformation

7c7651a

sigadamvenkata approved these changes Dec 8, 2025

View reviewed changes

JackySun9 self-requested a review December 8, 2025 22:23

sukamat mentioned this pull request Dec 9, 2025

MWPW-179655: Update config lingo adobecom/da-bacom#77

Open

lingo link transformation #5164

Are you sure you want to change the base?

lingo link transformation #5164

Conversation

vhargrave commented Nov 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Milo

CC

DA-BACOM

Uh oh!

aem-code-sync bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sigadamvenkata commented Dec 3, 2025

Uh oh!

vhargrave commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NadiiaSokolova left a comment

Choose a reason for hiding this comment

Uh oh!

sukamat commented Dec 3, 2025

Uh oh!

zagi25 left a comment

Choose a reason for hiding this comment

Uh oh!

skumar09 commented Dec 4, 2025

Uh oh!

afmicka left a comment

Choose a reason for hiding this comment

Uh oh!

Brandon32 left a comment

Choose a reason for hiding this comment

Uh oh!

sukamat commented Dec 7, 2025

Uh oh!

vhargrave commented Dec 8, 2025

Uh oh!

sigadamvenkata commented Dec 8, 2025

Uh oh!

Ruchika4 commented Dec 8, 2025

Uh oh!

vhargrave commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

vhargrave commented Nov 26, 2025 •

edited by github-actions bot

Loading

aem-code-sync bot commented Nov 26, 2025 •

edited

Loading

vhargrave commented Dec 3, 2025 •

edited

Loading