-
Notifications
You must be signed in to change notification settings - Fork 233
Description
I've prepared a patch for version 136.0.7103.113 that fixes linker errors related to ungoogled_switches.
The issue was that several build targets were missing the required dependency. The patch adds "//components/ungoogled:ungoogled_switches" to the deps section in the following BUILD.gn files:
//components/embedder_support/BUILD.gn//third_party/blink/common/BUILD.gn//third_party/blink/renderer/core/BUILD.gn
However, I encountered a problem when trying to submit a Pull Request. GitHub shows the error: "There isn’t anything to compare. main and my-branch are entirely different commit histories."
Could you please advise on the correct workflow to contribute patches for a specific version tag like 136.0.7103.113? Should I attach the patch file to an issue instead, or is there a different branch I should target for such fixes?
Thank you for your guidance and for maintaining this project!
Patch:
From 6040627268a1535ad353b7176ecb1bf3d4dc4840 Mon Sep 17 00:00:00 2001
From: xxxx <[email protected]>
Date: Sat, 6 Sep 2025 22:00:30 +0800
Subject: [PATCH] Add ungoogled_switches dependency to BUILD.gn files
---
.../002-user-agent-fingerprint.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/patches/extra/fingerprint/002-user-agent-fingerprint.patch b/patches/extra/fingerprint/002-user-agent-fingerprint.patch
index 3b998a09..a6d26640 100755
--- a/patches/extra/fingerprint/002-user-agent-fingerprint.patch
+++ b/patches/extra/fingerprint/002-user-agent-fingerprint.patch
@@ -361,3 +361,33 @@ index 281e6a8c66..3e21126f25 100644
// ShouldSendClientHint is called to make sure UA is controlled by
// Permissions Policy.
if (ShouldSendClientHint(*policy, resource_origin, is_1p_origin,
+--- a/components/embedder_support/BUILD.gn
++++ b/components/embedder_support/BUILD.gn
+@@ -60,6 +60,7 @@
+ "//build/util:chromium_git_revision",
+ "//components/policy/core/common",
+ "//components/prefs",
++ "//components/ungoogled:ungoogled_switches",
+ "//components/version_info",
+ "//net",
+ "//third_party/blink/public/common:headers",
+--- a/third_party/blink/common/BUILD.gn
++++ b/third_party/blink/common/BUILD.gn
+@@ -304,6 +304,7 @@
+ "//base",
+ "//build:android_buildflags",
+ "//build:chromecast_buildflags",
++ "//components/ungoogled:ungoogled_switches",
+ "//media/capture:capture_base",
+ "//media/capture/mojom:video_capture_mojom_support",
+ "//mojo/public/cpp/system",
+--- a/third_party/blink/renderer/core/BUILD.gn
++++ b/third_party/blink/renderer/core/BUILD.gn
+@@ -383,6 +383,7 @@
+ "//components/paint_preview/common",
+ "//components/performance_manager/public/mojom:mojom_blink",
+ "//components/shared_highlighting/core/common",
++ "//components/ungoogled:ungoogled_switches",
+ "//components/web_package",
+ "//gin",
+ "//gpu/config",
--
2.42.0