-
Notifications
You must be signed in to change notification settings - Fork 505
feat:[response_format] Bedrock client structured output #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So Im testing out the new changes here but I seem to be getting an error with my async tool calls not being awaited |
solved in this PR: |
|
So the changes in 2221 solved the async. Agent runs but when it tries to call |
|
@priyansh4320 Please add integration tests with real API calls. |
|
@priyansh4320 sorry to be impatient but wanted to check in on this |
@DanCorvesor integration tests should be done by today. and then we will merge bedrock PRs. :) thank you checking. |
|
Did you see @KojoOwusu 's above comment tho, seems we've found an issue |
Keep branch version of test/oai/test_bedrock.py
marklysze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @priyansh4320, nice work!
Codecov Report❌ Patch coverage is
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Why are these changes needed?
This pull removes the bedrock unsupported warning on structured output / response_format param and adds support for response format referanced via beedrock documentation.
https://aws.amazon.com/blogs/machine-learning/structured-data-response-with-amazon-bedrock-prompt-engineering-and-tool-use/
Related issue number
#2225
Checks