Skip to content

chore: Update the UCX ver to 1.20.0 #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2025
Merged

chore: Update the UCX ver to 1.20.0 #988

merged 5 commits into from
Nov 11, 2025

Conversation

@Alexey-Rivkin
Copy link
Contributor

@Alexey-Rivkin Alexey-Rivkin commented Nov 4, 2025

What?

Update the UCX ver to 1.20.0

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

👋 Hi Alexey-Rivkin! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@Alexey-Rivkin
Copy link
Contributor Author

Alexey-Rivkin commented Nov 4, 2025

/build

2 similar comments
@Alexey-Rivkin
Copy link
Contributor Author

Alexey-Rivkin commented Nov 4, 2025

/build

@Alexey-Rivkin
Copy link
Contributor Author

Alexey-Rivkin commented Nov 4, 2025

/build

@Alexey-Rivkin
Copy link
Contributor Author

Alexey-Rivkin commented Nov 4, 2025

Depends on the UCX v1.20 release

brminich
brminich reviewed Nov 6, 2025
View reviewed changes
@Alexey-Rivkin
chore: Use UCX v1.20.x branch instead of v1.20.0 tag
4e9e456 
The v1.20.0 release doesn't exist yet. Switch to v1.20.x branch
which contains the pre-release code for UCX 1.20 series.

Signed-off-by: Alexey Rivkin <[email protected]>
@Alexey-Rivkin
Merge remote-tracking branch 'origin/main' into bump_UCX_ver
9a279d0
@Alexey-Rivkin
Copy link
Contributor Author

Alexey-Rivkin commented Nov 6, 2025

/build

@Alexey-Rivkin Alexey-Rivkin marked this pull request as ready for review November 6, 2025 12:25
@Alexey-Rivkin Alexey-Rivkin requested review from a team as code owners November 6, 2025 12:25
@brminich
Copy link
Contributor

brminich commented Nov 10, 2025

@dpressle can we merge this?
@ovidiusm for vis

@brminich
Copy link
Contributor

brminich commented Nov 10, 2025

/build

ovidiusm
ovidiusm approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@ovidiusm ovidiusm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, because we have done it like this before, but it would be better to have a way to fix the exact commit instead of pointing to the branch, to have reproducible builds. Otherwise what is tested in verification might not be what is shipped in PyPi or dynamo

@dpressle
Copy link
Contributor

dpressle commented Nov 10, 2025

@dpressle can we merge this? @ovidiusm for vis

Did we released ucx 1.20 in GH? do we have tarball for that version? i think we have some processes that downloads these packages and not cloning

@ovidiusm
Copy link
Contributor

ovidiusm commented Nov 10, 2025

No, UCX 1.20 has not been released yet, 1.20.x is a release branch. That's why I am wondering if it might be better to point to the latest hash on the branch instead of the branch itself

@Alexey-Rivkin
Copy link
Contributor Author

Alexey-Rivkin commented Nov 10, 2025

No, UCX 1.20 has not been released yet, 1.20.x is a release branch. That's why I am wondering if it might be better to point to the latest hash on the branch instead of the branch itself

@brminich WDYT?

@brminich
Copy link
Contributor

brminich commented Nov 11, 2025

No, UCX 1.20 has not been released yet, 1.20.x is a release branch. That's why I am wondering if it might be better to point to the latest hash on the branch instead of the branch itself

@brminich WDYT?

IMO, pointing to the branch is ok, because it is release branch and we expect that only critical fixes will be merged there.
1.20 is not released yet, which is fine imo. AFAIR, we did the same with 1.19

@brminich
Copy link
Contributor

brminich commented Nov 11, 2025

/build

@ovidiusm
Copy link
Contributor

ovidiusm commented Nov 11, 2025

Then I am also OK with using 1.20.x

@ovidiusm ovidiusm merged commit 6e36cfa into ai-dynamo:main Nov 11, 2025
21 checks passed
e-ago pushed a commit to e-ago/nixl-doca-31 that referenced this pull request Nov 12, 2025
@Alexey-Rivkin @brminich @eagonv
chore: Update the UCX ver to 1.20.0 (ai-dynamo#988)
fe097e3 
* chore: Update the UCX ver to 1.20.0

Signed-off-by: Alexey Rivkin <[email protected]>

* chore: Use UCX v1.20.x branch instead of v1.20.0 tag

The v1.20.0 release doesn't exist yet. Switch to v1.20.x branch
which contains the pre-release code for UCX 1.20 series.

Signed-off-by: Alexey Rivkin <[email protected]>

---------

Signed-off-by: Alexey Rivkin <[email protected]>
Co-authored-by: Mikhail Brinskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brminich brminich brminich approved these changes

@dpressle dpressle dpressle approved these changes

@ovidiusm ovidiusm ovidiusm approved these changes

Assignees

No one assigned

Labels

external-contribution size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alexey-Rivkin @brminich @dpressle @ovidiusm