-
Notifications
You must be signed in to change notification settings - Fork 114
Description
I tried the docker installation and there is some errors while building the image.
Just a quick review of the implementation of docker in general and I can see there's some services that are build inside the image (Ex.: Redis) while this service could be called individually in the docker-compose.yml, at least I think this should be the optimal way of implementing services. And this way we can lock the version of the service and separate it from the rest of the build (app that was developed).
I will make a fork and PR and try to review the full installation and implementation of the project with docker. It can take some time, and I will probably need some help with some questions, but I will do my best.
I'm going to try to leave a list of how this should be implemented or things I think should be optimized:
- Improve readability of the
docker-compose.ymlfile - Review
Dockerfileto solve errors while building image - Review Services that are build inside the
Dockerfilewith theinstalling_deps.shscripts - After reviewing the
Dockerfile, review thedocker-compose.ymlfile with the new services - The final objective should be build the image and after that we should only execute
docker compose up -dand the project should be up and running.