Skip to content

feat: microoptimize _LRUCacheWrapper._task_done_callback #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: microoptimize _LRUCacheWrapper._task_done_callback #684

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edc5a1b
feat: microoptimize `_LRUCacheWrapper._task_done_callback`
BobTheBuidler Aug 15, 2025
c47ab35
Merge branch 'master' into callback
Dreamsorcerer Sep 27, 2025
4d5e3f0
lint
BobTheBuidler Sep 27, 2025
f155143
Merge branch 'master' into callback
BobTheBuidler Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions async_lru/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,23 +172,24 @@ def _task_done_callback(
) -> None:
self.__tasks.discard(task)

cache = self.__cache

if task.cancelled():
fut.cancel()
self.__cache.pop(key, None)
cache.pop(key, None)
return

exc = task.exception()
if exc is not None:
fut.set_exception(exc)
self.__cache.pop(key, None)
cache.pop(key, None)
return

cache_item = self.__cache.get(key)
if self.__ttl is not None and cache_item is not None:
cache_item = cache.get(key)
ttl = self.__ttl
if ttl is not None and cache_item is not None:
loop = asyncio.get_running_loop()
cache_item.later_call = loop.call_later(
self.__ttl, self.__cache.pop, key, None
)
cache_item.later_call = loop.call_later(ttl, cache.pop, key, None)

fut.set_result(task.result())

Expand Down
Loading