cleanup

Author: mwbayley

airbyte-cdk/bulk/core/base/src/main/kotlin/io/airbyte/cdk/data/JsonCodec.kt

@@ -336,6 +336,7 @@ data class ArrayEncoder<T>(
     override fun encode(decoded: List<T>): JsonNode =
         Jsons.arrayNode().apply {
             for (e in decoded) {
+                // Note: in generics, T can be nullable!
                 if (e == null) add(NullCodec.encode(e)) else add(elementEncoder.encode(e))
             }
         }

airbyte-cdk/bulk/toolkits/source-tests/src/testFixtures/kotlin/io/airbyte/cdk/test/fixtures/tests/FieldTypeMapperTest.kt

@@ -241,9 +241,6 @@ abstract class FieldTypeMapperTest {
                 return mapOf(
                     tableName.uppercase() to
                         values.values.map {
-                            // TODO: don't break existing tests
-                            // Jsons.readTree("""{"${columnName.uppercase()}":$it}""")
-                            // val colName = entityNameDefaultCapitalization.transform(columnName)
                             Jsons.readTree("""{"${columnName}":$it}""")
                         }
                 )
@@ -266,14 +263,6 @@ abstract class FieldTypeMapperTest {
 
 object AnsiSql {
 
-    val floatValues =
-        mapOf(
-            "null" to "null",
-            "45.67" to "45.67",
-            "98.76" to "98.76",
-            "0.12" to "0.12",
-        )
-
     val intValues =
         mapOf(
             "null" to "null",
@@ -357,13 +346,6 @@ object AnsiSql {
             "''" to "\"\"",
         )
 
-    val binary20Values =
-        mapOf(
-            "null" to "null",
-            "X'0123'" to "\"ASMAAAAAAAAAAAAAAAAAAAAAAAA=\"",
-            "X'0123456789ABCDEF'" to "\"ASNFZ4mrze8AAAAAAAAAAAAAAAA=\"",
-        )
-
     val dateValues =
         mapOf(
             "null" to "null",

airbyte-integrations/connectors/source-postgres/src/main/kotlin/io/airbyte/integrations/source/postgres/PostgresSource.kt

@@ -17,13 +17,6 @@ object PostgresSource {
                 log.info { (File(arg).readText()) }
             }
         }
-        val rootPath = "/Users/matt.bayley/dev/airbyte/secrets/airbyte/postgres"
-        val configPath = "$rootPath/config.json"
-        val catalogPath = "$rootPath/catalog.json"
-        val statePath = "$rootPath/state.json"
-        val checkArgs = arrayOf("--check", "--config", configPath)
-        val discoverArgs = arrayOf("--discover", "--config", configPath)
-        val readArgs = arrayOf("--read", "--config", configPath, "--catalog", catalogPath)
-        AirbyteSourceRunner.run(*readArgs)
+        AirbyteSourceRunner.run(*args)
     }
 }

airbyte-integrations/connectors/source-postgres/src/test/kotlin/io/airbyte/integrations/source/postgres/PostgresSourceFieldTypeMapperTest.kt

@@ -88,7 +88,6 @@ class PostgresSourceFieldTypeMapperTest : FieldTypeMapperTest() {
                 "'A'" to "\"A\"",
             )
         )
-        // TODO: Old version maps BIT to text and BIT[] to Array<Boolean>(?!?)
         scalarAndArray(
             "BIT(1)",
             LeafAirbyteSchemaType.BOOLEAN,
@@ -153,7 +152,6 @@ class PostgresSourceFieldTypeMapperTest : FieldTypeMapperTest() {
             LeafAirbyteSchemaType.DATE,
             AnsiSql.dateValues.plus(preservedInfinities).mapKeys { "${it.key}::date" }
         )
-
         scalarAndArray(
             "TIME",
             LeafAirbyteSchemaType.TIME_WITHOUT_TIMEZONE,