Add nushell completion for __zoxide_z #1129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juhan280
force-pushed
the
nushell_completion
branch
from
f1080b3 to
5cc4f1a
Compare
ysthakur
reviewed
Nov 13, 2025
ysthakur
left a comment
ysthakur
left a comment
There was a problem hiding this comment.
Random Nushell user here. Thanks for this! I have some minor comments
| def "nu-complete __zoxide_z" [context: string] { | ||
| let ast = ast --flatten $context | skip 1 | ||
|
|
||
| # If the user has typed a space after the first argument, use the custom |
There was a problem hiding this comment.
I don't think $ast will be nonempty only if you add a space after the first argument. ast -f "z foo" (no space after foo) is still a length 2 list.
Suggested change
| # If the user has typed a space after the first argument, use the custom | |
| # If the user has entered an argument, use the custom |
Author
There was a problem hiding this comment.
If you look at the next few lines, I compare the output of ast with the length of the $context, thats how I tell if there is an extra space after the first arg or not.
if $ast.0.span.end >= ($context | str length) { return null }| # | ||
| {{ section }} | ||
| # Completion for __zoxide_z | ||
| # |
There was a problem hiding this comment.
What's this for? The extra # and the blank line below, I mean.
Author
There was a problem hiding this comment.
To match the formating of other section headers in the file
{{ section }}
# Hook configuration for zoxide.
# {{ section }}
# When using zoxide with --no-cmd, alias these internal functions as desired.
#
Juhan280
force-pushed
the
nushell_completion
branch
from
5cc4f1a to
17cc8dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nushell/nushell#15888 added support for completions to replace multiple arguments. This allows us to define a completion which replaces all the keywords with the correct file path upon accepting the path.
Also wrapped the whole script into a nushell module to prevent the completion command from polluting the command namespace. (That's why (the indentation) the diff is so messy, sorry)