Improve init

Author: ije

server/aleph.ts

@@ -117,7 +117,7 @@ export class Aleph implements IAleph {
       this.#pageRouting = new Routing(this.#config)
     }
 
-    await fixConfigAndImportMap(this.#workingDir, this.#config, this.#importMap)
+    await fixConfigAndImportMap(this.#workingDir, this.#config, this.#importMap, importMapFile)
     ms.stop('load config')
 
     Deno.env.set('ALEPH_ENV', this.#mode)
@@ -129,24 +129,32 @@ export class Aleph implements IAleph {
     const srcDir = join(this.#workingDir, this.#config.srcDir)
     const apiDir = join(srcDir, 'api')
     const pagesDir = join(srcDir, 'pages')
-    const buildManifestFile = join(this.#buildDir, 'build.manifest.json')
+    const manifestFile = join(this.#buildDir, 'build.manifest.json')
     const importMapString = JSON.stringify(this.#importMap)
     const pluginNames = this.#config.plugins.map(({ name }) => name).join(',')
 
-    let shouldRebuild = !await existsFile(buildManifestFile)
-    let saveManifestFile = shouldRebuild
+    let shouldRebuild = !await existsFile(manifestFile)
+    let shouldUpdateManifest = shouldRebuild
     if (!shouldRebuild) {
       try {
-        const v = JSON.parse(await Deno.readTextFile(buildManifestFile))
+        const v = JSON.parse(await Deno.readTextFile(manifestFile))
+        const confirmClean = (msg: string): boolean => {
+          shouldUpdateManifest = true
+          // in 'prodcution' mode, we don't ask user to clean build cache
+          if (!this.isDev) {
+            return true
+          }
+          return confirm(msg)
+        }
         shouldRebuild = (
           typeof v !== 'object' ||
           v === null ||
           v.compiler !== wasmChecksum ||
-          (v.importMap !== importMapString && confirm('The import-maps has been changed, clean build cache?')) ||
-          (v.plugins !== pluginNames && confirm('The plugin list has been updated, clean build cache?'))
+          (v.importMap !== importMapString && confirmClean('The import-maps has been changed, clean build cache?')) ||
+          (v.plugins !== pluginNames && confirmClean('The plugin list has been updated, clean build cache?'))
         )
-        if (!shouldRebuild && v.importMap !== importMapString && v.plugins !== pluginNames) {
-          saveManifestFile = true
+        if (shouldRebuild) {
+          shouldUpdateManifest = true
         }
       } catch (e) { }
     }
@@ -159,9 +167,8 @@ export class Aleph implements IAleph {
       await ensureDir(this.#buildDir)
     }
 
-    if (saveManifestFile) {
-      log.debug('rebuild...')
-      ensureTextFile(buildManifestFile, JSON.stringify({
+    if (shouldUpdateManifest) {
+      ensureTextFile(manifestFile, JSON.stringify({
         aleph: VERSION,
         deno: Deno.version.deno,
         compiler: wasmChecksum,

server/config.ts

@@ -1,10 +1,12 @@
+import { bold } from 'https://deno.land/[email protected]/fmt/colors.ts'
 import { basename, join } from 'https://deno.land/[email protected]/path/mod.ts'
 import type { ReactOptions } from '../compiler/mod.ts'
 import { defaultReactVersion } from '../shared/constants.ts'
 import { existsDir } from '../shared/fs.ts'
 import log from '../shared/log.ts'
 import util from '../shared/util.ts'
 import type { BrowserName, Config, RequiredConfig as TRequiredConfig, ImportMap, PostCSSPlugin } from '../types.d.ts'
+import { VERSION } from '../version.ts'
 import { getAlephPkgUri } from './helper.ts'
 
 export type RequiredConfig = TRequiredConfig & {
@@ -192,7 +194,7 @@ export async function loadImportMap(importMapFile: string): Promise<ImportMap> {
  * - fix import map when the `srcDir` does not equal '/'
  * - respect react version in import map
  */
-export async function fixConfigAndImportMap(workingDir: string, config: RequiredConfig, importMap: ImportMap) {
+export async function fixConfigAndImportMap(workingDir: string, config: RequiredConfig, importMap: ImportMap, importMapFile: string | null) {
   // set default src directory
   if (
     config.srcDir === '/' &&
@@ -202,17 +204,38 @@ export async function fixConfigAndImportMap(workingDir: string, config: Required
     config.srcDir = '/src'
   }
 
-  Object.keys(importMap.imports).forEach(key => {
-    const url = importMap.imports[key]
-    // strip `srcDir` prefix
-    if (config.srcDir !== '/' && url.startsWith('.' + config.srcDir)) {
-      importMap.imports[key] = '.' + util.trimPrefix(url, '.' + config.srcDir)
-    }
-    // react verison should respect the import maps
-    if (/\/\/esm\.sh\/react@\d+\.\d+\.\d+(-[a-z0-9\.]+)?$/.test(url)) {
-      config.react.version = url.split('@').pop()!
+  if (importMapFile) {
+    let imports = { ...importMap.imports }
+    let updateImportMaps: boolean | null = null
+
+    Object.keys(importMap.imports).forEach(key => {
+      const url = importMap.imports[key]
+      // strip `srcDir` prefix
+      if (config.srcDir !== '/' && url.startsWith('.' + config.srcDir)) {
+        importMap.imports[key] = '.' + util.trimPrefix(url, '.' + config.srcDir)
+      }
+      // fix Aleph.js version
+      if (/\/\/deno\.land\/x\/aleph@v?\d+\.\d+\.\d+(-[a-z0-9\.]+)?\//.test(url)) {
+        const [prefix, rest] = util.splitBy(url, '@')
+        const [version, suffix] = util.splitBy(rest, '/')
+        if (version !== 'v' + VERSION && updateImportMaps === null) {
+          updateImportMaps = confirm(`You are using a different version of Aleph.js, expect ${version} -> v${bold(VERSION)}, update '${basename(importMapFile)}'?`)
+        }
+        if (updateImportMaps) {
+          imports[key] = `${prefix}@v${VERSION}/${suffix}`
+        }
+      }
+      // react verison should respect the import maps
+      if (/\/\/esm\.sh\/react@\d+\.\d+\.\d+(-[a-z0-9\.]+)?$/.test(url)) {
+        config.react.version = url.split('@').pop()!
+      }
+    })
+
+    if (updateImportMaps) {
+      const json = JSON.stringify({ ...importMap, imports }, undefined, 2)
+      await Deno.writeTextFile(importMapFile, json)
     }
-  })
+  }
 }
 
 function isFramework(v: any): v is 'react' {