perf: Use a memoized key lookup for rules #615
+100
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my project, this makes ESLint as a whole roughly 8% faster, and it seems to result in consistently faster benchmarks. Note a behavior change - member expressions used to find the first matching rule, while they now favor the more general rule if relevant. (I believe this change is an improvement: "Promise is not supported in IE 10" is a more helpful message than "Promise.reject() is not supported in IE 10".)
Author
|
Sorry to nag, but is there anything I can do to help things progress with this PR? I'd love to benefit from the performance improvements in my projects if it's not too much trouble. |
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my project, this makes ESLint as a whole roughly 8% faster, and it seems to result in consistently faster benchmarks.
Note a behavior change - member expressions used to find the first matching rule, while they now favor the more general rule if relevant. (I believe this change is an improvement: "Promise is not supported in IE 10" is a more helpful message than "Promise.reject() is not supported in IE 10".)