Fix tiny image detection inside responsive parent #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
update/tiny-image-detection
branch
from
6cd61a3 to
40144be
Compare
westonruter
added a commit
to ampproject/amp-wp
that referenced
this pull request
Apr 10, 2021
4 tasks
schlessera
approved these changes
Apr 10, 2021
schlessera
added
DOM
Optimizer
SSR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when an
amp-imghad afilllayout and it was inside of a parent which was responsive (with 16x9 dimensions on anamp-youtube), theisTinycheck was returning true unexpectedly. This updates thegetDimensionsFromParentlogic to return the max integer as the width/height when the element has a responsive layout.Also renames
Element::addAttributes()toElement::setAttributes()per #119 (comment).