Skip to content

Commit cdea0a3

Browse files
committed
fix test cases
1 parent cd9fbfb commit cdea0a3

File tree

4 files changed

+34
-17
lines changed

4 files changed

+34
-17
lines changed

webrtc-android-framework/src/main/java/io/antmedia/webrtcandroidframework/core/StatsCollector.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ private void parseStats(RTCStatsReport report) {
9696
if(value.getMembers().containsKey(SSRC)) {
9797
TrackStats audioTrackStats = publishStats.getAudioTrackStats();
9898

99-
long packetsSent = ((Long) value.getMembers().get(PACKETS_SENT)).longValue();
99+
long packetsSent = ((BigInteger) value.getMembers().get(PACKETS_SENT)).longValue();
100100
audioTrackStats.setPacketsSent(packetsSent);
101101

102102
BigInteger bytesSent = ((BigInteger) value.getMembers().get(BYTES_SENT));
@@ -141,7 +141,7 @@ private void parseStats(RTCStatsReport report) {
141141
}
142142

143143
if (value.getMembers().containsKey(PACKETS_SENT)) {
144-
long packetsSent = ((Long) value.getMembers().get(PACKETS_SENT)).longValue();
144+
long packetsSent = ((BigInteger) value.getMembers().get(PACKETS_SENT)).longValue();
145145
videoTrackStats.setPacketsSent(packetsSent);
146146
}
147147

webrtc-android-framework/src/main/java/io/antmedia/webrtcandroidframework/core/WebRTCClient.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1383,19 +1383,17 @@ public void onIceDisconnected(String streamId) {
13831383
config.webRTCListener.onIceDisconnected(streamId);
13841384
}
13851385

1386-
if (peers.size() == 1) {
1387-
if (streamStoppedByUser) {
1388-
release(true);
1389-
return;
1390-
}
1391-
1392-
if (config.reconnectionEnabled) {
1393-
rePublishPlay();
1394-
}
1395-
1396-
if (isConference()) {
1397-
releaseRemoteRenderers();
1398-
}
1386+
if (streamStoppedByUser) {
1387+
release(true);
1388+
return;
1389+
}
1390+
1391+
if (config.reconnectionEnabled) {
1392+
rePublishPlay();
1393+
}
1394+
1395+
if (isConference()) {
1396+
releaseRemoteRenderers();
13991397
}
14001398

14011399
});

webrtc-android-framework/src/test/java/io/antmedia/webrtcandroidframework/WebRTCClientTest.java

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
import io.antmedia.webrtcandroidframework.api.IDataChannelObserver;
7575
import io.antmedia.webrtcandroidframework.api.IWebRTCClient;
7676
import io.antmedia.webrtcandroidframework.api.IWebRTCListener;
77+
import io.antmedia.webrtcandroidframework.api.PlayParams;
7778
import io.antmedia.webrtcandroidframework.apprtc.AppRTCAudioManager;
7879
import io.antmedia.webrtcandroidframework.core.BlackFrameSender;
7980
import io.antmedia.webrtcandroidframework.core.CustomVideoCapturer;
@@ -209,6 +210,7 @@ public void testStreamPlayParameters() {
209210
String streamId = "stream" + RandomStringUtils.random(5);
210211
String token = "token" + RandomStringUtils.random(5);
211212
String subscriberId = "mySubscriber" + RandomStringUtils.random(5);
213+
String subscriberName = "name" + RandomStringUtils.random(5);
212214
String subscriberCode = "code" + RandomStringUtils.random(5);
213215
String viewerInfo = "info" + RandomStringUtils.random(5);
214216

@@ -220,9 +222,20 @@ public void testStreamPlayParameters() {
220222
webRTCClient.setAudioEnabled(audioCallEnabled);
221223
webRTCClient.setVideoEnabled(videoCallEnabled);
222224

223-
webRTCClient.play(streamId, token, null, subscriberId, subscriberCode, viewerInfo);
225+
PlayParams params = new PlayParams();
226+
params.setStreamId(streamId);
227+
params.setToken(token);
228+
params.setTracks(null);
229+
params.setSubscriberId(subscriberId);
230+
params.setSubscriberName(subscriberName);
231+
params.setSubscriberCode(subscriberCode);
232+
params.setViewerInfo(viewerInfo);
233+
params.setDisableTracksByDefault(false);
224234

225-
verify(wsHandler, times(1)).startPlay(streamId, token, null, subscriberId, "", subscriberCode, viewerInfo, false);
235+
236+
webRTCClient.play(params);
237+
238+
verify(wsHandler, times(1)).startPlay(streamId, token, null, subscriberId, subscriberName, subscriberCode, viewerInfo, false);
226239

227240
ArgumentCaptor<String> jsonCaptor = ArgumentCaptor.forClass(String.class);
228241
verify(wsHandler, times(1)).sendTextMessage(jsonCaptor.capture());
@@ -233,9 +246,12 @@ public void testStreamPlayParameters() {
233246
json.put(WebSocketConstants.STREAM_ID, streamId);
234247
json.put(WebSocketConstants.TOKEN, token);
235248
json.put(WebSocketConstants.SUBSCRIBER_ID, subscriberId);
249+
json.put(WebSocketConstants.SUBSCRIBER_NAME, subscriberName);
236250
json.put(WebSocketConstants.SUBSCRIBER_CODE, subscriberCode);
237251
json.put(WebSocketConstants.VIEWER_INFO, viewerInfo);
238252
json.put(WebSocketConstants.TRACK_LIST, new JSONArray());
253+
json.put(WebSocketConstants.DISABLE_TRACKS_BY_DEFAULT, false);
254+
239255
} catch (JSONException e) {
240256
e.printStackTrace();
241257
}
@@ -351,9 +367,11 @@ public void testJoinRoomParameters() {
351367
jsonPlay.put(WebSocketConstants.STREAM_ID, roomName);
352368
jsonPlay.put(WebSocketConstants.TOKEN, "");
353369
jsonPlay.put(WebSocketConstants.SUBSCRIBER_ID, "");
370+
jsonPlay.put(WebSocketConstants.SUBSCRIBER_NAME, "");
354371
jsonPlay.put(WebSocketConstants.SUBSCRIBER_CODE, "");
355372
jsonPlay.put(WebSocketConstants.VIEWER_INFO, "");
356373
jsonPlay.put(WebSocketConstants.TRACK_LIST, new JSONArray());
374+
jsonPlay.put(WebSocketConstants.DISABLE_TRACKS_BY_DEFAULT, false);
357375
} catch (JSONException e) {
358376
e.printStackTrace();
359377
}

webrtc-android-framework/src/test/java/io/antmedia/webrtcandroidframework/WebSocketHandlerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ public void testStartPlay() throws JSONException {
194194
expectedJson.put(WebSocketConstants.SUBSCRIBER_CODE, subscriberCode);
195195
expectedJson.put(WebSocketConstants.SUBSCRIBER_NAME, subscriberName);
196196
expectedJson.put(WebSocketConstants.VIEWER_INFO, viewerInfo);
197+
expectedJson.put(WebSocketConstants.DISABLE_TRACKS_BY_DEFAULT, false);
197198

198199
assertEquals(expectedJson.toString(), jsonCaptor.getValue());
199200
}

0 commit comments

Comments
 (0)