Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Oct 27, 2025

Rationale for this change

Dir.empty? fails with nonexistent directory.

What changes are included in this PR?

Add Dir.exist? before Dir.empty?.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #47948 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 27, 2025
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 27, 2025
@raulcd raulcd merged commit d9697b1 into apache:main Oct 27, 2025
29 of 32 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 27, 2025
@kou kou deleted the ci-deb-test branch October 27, 2025 08:24
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d9697b1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Extra: Package: Linux Run extra Linux Packages CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants