fix(backend): Skip interconnect initialization for auxiliary background workers #1457
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
reviewed
Nov 28, 2025
zhan7236
force-pushed
the
fix/aux-process-socket-issue-1389
branch
from
ef16f2b to
f040fd4
Compare
…kers Fix issue apache#1389: Auxiliary processes (ftsprobe, global deadlock detector, dtx recovery, sweeper, pg_cron launcher) currently open unnecessary network sockets for interconnect communication they don't need. Per review feedback, instead of adding checks inside cdb_setup/cdb_cleanup functions, skip calling these functions entirely for auxiliary background workers in InitPostgres(). This resolves the security concern of having unnecessary open network ports and reduces resource usage.
my-ship-it
force-pushed
the
fix/aux-process-socket-issue-1389
branch
from
f040fd4 to
db1a32c
Compare
my-ship-it
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #1389 by preventing auxiliary background worker processes from opening unnecessary network sockets during interconnect initialization.
Problem
Auxiliary background workers (ftsprobe, global deadlock detector, dtx recovery, sweeper, pg_cron launcher, ic proxy) were initializing the Motion Layer IPC, which opens network sockets for data exchange. Since these processes don't require interconnect communication, this behavior is unnecessary and can be considered a security concern.
Solution
Added a check for
amAuxiliaryBgWorker()in bothcdb_setup()andcdb_cleanup()functions to skip interconnect initialization and cleanup for auxiliary background workers.Changes:
src/backend/cdb/cdbutil.c:!amAuxiliaryBgWorker()condition tocdb_setup()to skipInitMotionLayerIPC()call!amAuxiliaryBgWorker()condition tocdb_cleanup()to skipCleanUpMotionLayerIPC()call#ifdef USE_INTERNAL_FTSand#elsecode pathsTesting
postmaster/postmaster.halready included in cdbutil.camAuxiliaryBgWorker()properly declared in postmaster.hFixes #1389