Skip to content

[bugfix] add incident publishing form validation #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zqr10159 merged 7 commits into from
Jun 26, 2024
Merged

[bugfix] add incident publishing form validation #2139

zqr10159 merged 7 commits into from
Jun 26, 2024

Conversation

@LiuTianyou
Copy link
Contributor

@LiuTianyou LiuTianyou commented Jun 25, 2024 •
edited
Loading

What's changed?

  1. add incident publishing form validation ([BUG] When publishing an event, if publish message is not filled in, an error will be reported #2138 )
  2. add status page add/edit component page form validation

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 requested a review from TJxiaobao June 25, 2024 14:49
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 25, 2024
@tomsun28 tomsun28 linked an issue Jun 25, 2024 that may be closed by this pull request
[BUG] When publishing an event, if publish message is not filled in, an error will be reported #2138
Closed
1 task
@zqr10159 zqr10159 merged commit dbac0df into apache:master Jun 26, 2024
@LiuTianyou LiuTianyou deleted the add-validate branch June 29, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zqr10159 zqr10159 zqr10159 approved these changes

@TJxiaobao TJxiaobao Awaiting requested review from TJxiaobao

Assignees

No one assigned

Labels

webapp

Projects

None yet

Milestone

1.6.1

Development

Successfully merging this pull request may close these issues.

[BUG] When publishing an event, if publish message is not filled in, an error will be reported

3 participants

@LiuTianyou @zqr10159 @tomsun28