-
Notifications
You must be signed in to change notification settings - Fork 78
feat(java,info): support multi-property in yaml #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yangxk1
merged 6 commits into
apache:main
from
yangxk1:778-support-multi-porperices-in-yaml
Dec 8, 2025
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -32,6 +32,11 @@ public abstract class BaseGraphInfoSaver implements GraphInfoSaver { | |||||
|
|
||||||
| @Override | ||||||
| public void save(URI graphInfoUri, GraphInfo graphInfo) throws IOException { | ||||||
| // if graphInfoUri is a directory then save to ${graphInfo.name}.graph.yml | ||||||
yangxk1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| if (graphInfoUri.getPath().endsWith("/")) { | ||||||
| graphInfoUri = | ||||||
| URI.create(graphInfoUri.toString() + graphInfo.getName() + ".graph.yaml"); | ||||||
| } | ||||||
| Writer writer = writeYaml(graphInfoUri); | ||||||
| graphInfo.dump(graphInfoUri, writer); | ||||||
| writer.close(); | ||||||
|
|
@@ -48,13 +53,22 @@ public void save(URI graphInfoUri, GraphInfo graphInfo) throws IOException { | |||||
|
|
||||||
| @Override | ||||||
| public void save(URI vertexInfoUri, VertexInfo vertexInfo) throws IOException { | ||||||
| // if vertexInfoUri is a directory then save to ${vertexInfo.type}.vertex.yml | ||||||
yangxk1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| if (vertexInfoUri.getPath().endsWith("/")) { | ||||||
| vertexInfoUri = | ||||||
| URI.create(vertexInfoUri.toString() + vertexInfo.getType() + ".vertex.yaml"); | ||||||
| } | ||||||
| Writer vertexWriter = writeYaml(vertexInfoUri); | ||||||
| vertexInfo.dump(vertexWriter); | ||||||
| vertexWriter.close(); | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
| public void save(URI edgeInfoUri, EdgeInfo edgeInfo) throws IOException { | ||||||
| // if edgeInfoUri is a directory then save to ${edgeInfo.getConcat()}.edge.yml | ||||||
|
||||||
| // if edgeInfoUri is a directory then save to ${edgeInfo.getConcat()}.edge.yml | |
| // if edgeInfoUri is a directory then save to ${edgeInfo.getConcat()}.edge.yaml |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use yml
59 changes: 59 additions & 0 deletions
59
maven-projects/info/src/main/java/org/apache/graphar/info/type/Cardinality.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.graphar.info.type; | ||
|
|
||
| /** Defines how multiple values are handled for a given property key. */ | ||
| public enum Cardinality { | ||
| /** Single value property */ | ||
| SINGLE, | ||
| /** List of values property */ | ||
| LIST, | ||
| /** Set of values property (no duplicates) */ | ||
| SET; | ||
|
|
||
yangxk1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public String toString() { | ||
| switch (this) { | ||
| case SINGLE: | ||
| return "single"; | ||
| case LIST: | ||
| return "list"; | ||
| case SET: | ||
| return "set"; | ||
| default: | ||
| throw new IllegalArgumentException("Unknown cardinality: " + this); | ||
| } | ||
| } | ||
|
|
||
| public static Cardinality fromString(String cardinality) { | ||
| if (cardinality == null) { | ||
| return null; | ||
| } | ||
| switch (cardinality) { | ||
| case "single": | ||
| return SINGLE; | ||
| case "list": | ||
| return LIST; | ||
| case "set": | ||
| return SET; | ||
| default: | ||
| throw new IllegalArgumentException("Unknown cardinality: " + cardinality); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.