Skip to content

Commit 9a22abe

Browse files
committed
Decouple InternalDelete and InternalData file class
1 parent 82c24e4 commit 9a22abe

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDeletionVector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
@Getter
3737
@ToString(callSuper = true)
3838
@EqualsAndHashCode(callSuper = true)
39-
public class InternalDeletionVector extends InternalDataFile {
39+
public class InternalDeletionVector extends InternalFile {
4040
// path (absolute with scheme) of data file to which this deletion vector belongs
4141
@NonNull String dataFilePath;
4242

xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionSource.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import org.apache.spark.sql.delta.actions.AddFile;
4141
import org.apache.spark.sql.delta.actions.RemoveFile;
4242

43+
import org.apache.xtable.model.storage.InternalFile;
4344
import scala.Option;
4445

4546
import io.delta.tables.DeltaTable;
@@ -164,7 +165,7 @@ public TableChange getTableChangeForCommit(Long versionNumber) {
164165
}
165166
}
166167

167-
List<InternalDataFile> allAddedFiles =
168+
List<InternalFile> allAddedFiles =
168169
Stream.concat(addedFiles.values().stream(), deletionVectors.values().stream())
169170
.collect(Collectors.toList());
170171
InternalFilesDiff internalFilesDiff =

xtable-core/src/test/java/org/apache/xtable/ValidationTestHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.apache.xtable.model.TableChange;
3232
import org.apache.xtable.model.storage.InternalDataFile;
3333
import org.apache.xtable.model.storage.InternalDeletionVector;
34+
import org.apache.xtable.model.storage.InternalFile;
3435

3536
public class ValidationTestHelper {
3637

@@ -98,8 +99,7 @@ public static List<String> getAllFilePaths(InternalSnapshot internalSnapshot) {
9899

99100
private static Set<String> extractPathsFromDataFile(Set<InternalDataFile> dataFiles) {
100101
return dataFiles.stream()
101-
.filter(file -> !(file instanceof InternalDeletionVector))
102-
.map(InternalDataFile::getPhysicalPath)
102+
.map(InternalFile::getPhysicalPath)
103103
.collect(Collectors.toSet());
104104
}
105105

0 commit comments

Comments
 (0)