Skip to content

Commit 511fe27

Browse files
authored
[MRESOLVER-440] Addendum (#382)
Seems the "atypical" modules like supplier and demo snippets were completely omitted from the transport rename, and were still using renamed transport-http instead the new transport-apache. --- https://issues.apache.org/jira/browse/MRESOLVER-440
1 parent 3e56c51 commit 511fe27

File tree

5 files changed

+9
-22
lines changed

5 files changed

+9
-22
lines changed

maven-resolver-demos/maven-resolver-demo-snippets/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
</dependency>
6666
<dependency>
6767
<groupId>org.apache.maven.resolver</groupId>
68-
<artifactId>maven-resolver-transport-http</artifactId>
68+
<artifactId>maven-resolver-transport-apache</artifactId>
6969
</dependency>
7070
<dependency>
7171
<groupId>org.apache.maven.resolver</groupId>

maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/supplier/SupplierRepositorySystemFactory.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.eclipse.aether.RepositorySystem;
2424
import org.eclipse.aether.spi.connector.transport.TransporterFactory;
2525
import org.eclipse.aether.supplier.RepositorySystemSupplier;
26-
import org.eclipse.aether.transport.http.ChecksumExtractor;
2726
import org.eclipse.aether.transport.jdk.JdkTransporterFactory;
2827
import org.eclipse.aether.transport.jetty.JettyTransporterFactory;
2928

@@ -34,9 +33,8 @@ public class SupplierRepositorySystemFactory {
3433
public static RepositorySystem newRepositorySystem() {
3534
return new RepositorySystemSupplier() {
3635
@Override
37-
protected Map<String, TransporterFactory> getTransporterFactories(
38-
Map<String, ChecksumExtractor> extractors) {
39-
Map<String, TransporterFactory> result = super.getTransporterFactories(extractors);
36+
protected Map<String, TransporterFactory> getTransporterFactories() {
37+
Map<String, TransporterFactory> result = super.getTransporterFactories();
4038
result.put(JdkTransporterFactory.NAME, new JdkTransporterFactory());
4139
result.put(JettyTransporterFactory.NAME, new JettyTransporterFactory());
4240
return result;

maven-resolver-supplier/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
</dependency>
6868
<dependency>
6969
<groupId>org.apache.maven.resolver</groupId>
70-
<artifactId>maven-resolver-transport-http</artifactId>
70+
<artifactId>maven-resolver-transport-apache</artifactId>
7171
</dependency>
7272

7373
<dependency>

maven-resolver-supplier/src/main/java/org/eclipse/aether/supplier/RepositorySystemSupplier.java

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,8 @@
120120
import org.eclipse.aether.spi.localrepo.LocalRepositoryManagerFactory;
121121
import org.eclipse.aether.spi.resolution.ArtifactResolverPostProcessor;
122122
import org.eclipse.aether.spi.synccontext.SyncContextFactory;
123+
import org.eclipse.aether.transport.apache.ApacheTransporterFactory;
123124
import org.eclipse.aether.transport.file.FileTransporterFactory;
124-
import org.eclipse.aether.transport.http.ChecksumExtractor;
125-
import org.eclipse.aether.transport.http.HttpTransporterFactory;
126-
import org.eclipse.aether.transport.http.Nexus2ChecksumExtractor;
127-
import org.eclipse.aether.transport.http.XChecksumChecksumExtractor;
128125
import org.eclipse.aether.util.version.GenericVersionScheme;
129126
import org.eclipse.aether.version.VersionScheme;
130127

@@ -300,17 +297,10 @@ protected Map<String, ProvidedChecksumsSource> getProvidedChecksumsSources(
300297
return result;
301298
}
302299

303-
protected Map<String, ChecksumExtractor> getChecksumExtractors() {
304-
HashMap<String, ChecksumExtractor> result = new HashMap<>();
305-
result.put(Nexus2ChecksumExtractor.NAME, new Nexus2ChecksumExtractor());
306-
result.put(XChecksumChecksumExtractor.NAME, new XChecksumChecksumExtractor());
307-
return result;
308-
}
309-
310-
protected Map<String, TransporterFactory> getTransporterFactories(Map<String, ChecksumExtractor> extractors) {
300+
protected Map<String, TransporterFactory> getTransporterFactories() {
311301
HashMap<String, TransporterFactory> result = new HashMap<>();
312302
result.put(FileTransporterFactory.NAME, new FileTransporterFactory());
313-
result.put(HttpTransporterFactory.NAME, new HttpTransporterFactory(extractors));
303+
result.put(ApacheTransporterFactory.NAME, new ApacheTransporterFactory());
314304
return result;
315305
}
316306

@@ -555,8 +545,7 @@ public RepositorySystem get() {
555545
Map<String, ProvidedChecksumsSource> providedChecksumsSources =
556546
getProvidedChecksumsSources(trustedChecksumsSources);
557547

558-
Map<String, ChecksumExtractor> checksumExtractors = getChecksumExtractors();
559-
Map<String, TransporterFactory> transporterFactories = getTransporterFactories(checksumExtractors);
548+
Map<String, TransporterFactory> transporterFactories = getTransporterFactories();
560549
TransporterProvider transporterProvider = getTransporterProvider(transporterFactories);
561550

562551
BasicRepositoryConnectorFactory basic = getBasicRepositoryConnectorFactory(

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
</dependency>
161161
<dependency>
162162
<groupId>org.apache.maven.resolver</groupId>
163-
<artifactId>maven-resolver-transport-http</artifactId>
163+
<artifactId>maven-resolver-transport-apache</artifactId>
164164
<version>${project.version}</version>
165165
</dependency>
166166
<dependency>

0 commit comments

Comments
 (0)