Skip to content

Conversation

@Himanshu-g81
Copy link
Contributor

@Himanshu-g81 Himanshu-g81 commented Nov 3, 2025

  1. Updated the implementation of triggerFailover to call HAStore API (HAGroupStoreManager.getInstance(conf).setHAGroupStatusToSync(haGroupName))
  2. Added support to handle 0 value of lastSyncTime from HA Store (as it's possible with new changes checked in). When it's 0, the first round is determined by taking the minimum across IN directories.
  3. Added the test cases for both the above scenario.

/**
* Test our recoverLease loop against mocked up filesystem.
*/
@Category(ParallelStatsDisabledTest.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be NeedsOwnMiniClusterTest.class

@tkhurana
Copy link
Contributor

tkhurana commented Nov 6, 2025

Actually, you need to move the ITs under src/it/java folder. It seems other tests have similar problems like ReplicationLogProcessorTest.java. So basically use the NeedsOwnMiniClusterTest.class and move to the IT folder. By convention IT classes end with IT keyword so you can rename these test classes too.

@Himanshu-g81 Himanshu-g81 requested a review from tkhurana November 7, 2025 13:05
@tkhurana tkhurana merged commit 11a1f5a into apache:PHOENIX-7562-feature Nov 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants