test: fix flaky MySQL integration test in test_update_v1_response

[sadpandajoe]

SUMMARY

Fixes intermittent test failure in tests/integration_tests/charts/commands_tests.py::TestChartsUpdateCommand::test_update_v1_response that occurred on MySQL due to datetime precision handling with the error:

FAILED tests/integration_tests/charts/commands_tests.py::TestChartsUpdateCommand::test_update_v1_response - 
assert datetime.datetime(2025, 11, 17, 18, 27, 41) != datetime.datetime(2025, 11, 17, 18, 27, 41) + 
where datetime.datetime(2025, 11, 17, 18, 27, 41) = Average and Sum Trends.last_saved_at

Root Cause:

• MySQL's DATETIME type defaults to second-level precision, truncating microseconds from Python's datetime.now()
• When the original test executed in under one second, timestamps appeared identical at second precision
• Initial fix attempt added .replace(microsecond=0) for comparison, but failed when last_saved_at was None

Solution:
Split the original test into two focused, deterministic tests:

1. test_update_sets_last_saved_at: Tests None → datetime transition
   - Explicitly sets last_saved_at = None before update
   - Verifies field gets populated after update
   - No sleep needed
2. test_update_changes_last_saved_at: Tests datetime → datetime transition
   - Seeds last_saved_at = datetime.now() before update
   - Sleeps 1 second to guarantee crossing second boundary for MySQL
   - Uses .replace(microsecond=0) for database-agnostic comparison
   - Verifies timestamp actually changed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #38e96e

Actionable Suggestions - 0

Additional Suggestions - 2

• tests/integration_tests/charts/commands_tests.py - 2

  • Assert statement used in test code · Line 393-393
    Using `assert` statements in test code is flagged by static analysis. Consider using `self.assertEqual()` or similar test framework assertions for better error reporting. Similar issues exist on lines 393 and 396.
    Code suggestion

     @@ -392,5 +392,5 @@
    -        # Normalize microseconds for database-agnostic comparison
    -        assert chart.last_saved_at.replace(microsecond=0) != last_saved_before.replace(
    -            microsecond=0
    -        )
    -        assert chart.last_saved_by == user
    +        # Normalize microseconds for database-agnostic comparison
    +        self.assertNotEqual(chart.last_saved_at.replace(microsecond=0), last_saved_before.replace(
    +            microsecond=0,
    +        ))
    +        self.assertEqual(chart.last_saved_by, user)

  • Missing trailing comma in function call · Line 394-394
    Missing trailing comma in multi-line function call on line 394. Adding trailing commas improves code consistency and reduces diff noise in version control.
    Code suggestion

     @@ -393,3 +393,3 @@
    -        assert chart.last_saved_at.replace(microsecond=0) != last_saved_before.replace(
    -            microsecond=0
    -        )
    +        assert chart.last_saved_at.replace(microsecond=0) != last_saved_before.replace(
    +            microsecond=0,
    +        )

Review Details

• Files reviewed - 1 · Commit Range: 9dc6dbb..9dc6dbb

  • tests/integration_tests/charts/commands_tests.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[Copilot]

Pull Request Overview

This PR fixes a flaky MySQL integration test in test_update_v1_response that intermittently fails due to MySQL's DATETIME type truncating microseconds to second-level precision.

Key changes:

• Added time.sleep(1) to ensure timestamps differ at second-level precision
• Modified timestamp comparison to normalize microseconds using .replace(microsecond=0) for database-agnostic behavior

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

[nitpick] After setting last_saved_at = datetime.now() and committing, the Python object may still contain microseconds that were truncated by MySQL during the database write. To ensure last_saved_before contains the actual database value (without microseconds), consider querying the chart fresh after the commit:

chart_to_update = db.session.query(Slice).get(pk)
chart_to_update.last_saved_at = datetime.now()
db.session.commit()
# Refresh to get the database value with truncated microseconds
chart_to_update = db.session.query(Slice).get(pk)
last_saved_before = chart_to_update.last_saved_at

This makes the test more explicit and avoids relying on ORM refresh behavior.

Suggested change

	db.session.commit()
	db.session.commit()
	# Refresh to get the database value with truncated microseconds
	chart_to_update = db.session.query(Slice).get(pk)

[sadpandajoe]

addressed

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[betodealmeida]

Thanks, this test was annoying!