Skip to content

Conversation

@ChristopherSchultz
Copy link
Contributor

Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another unrelated thing, it might be better to unify the coding style?
eg:

for() {
   // code
}

not:

for()
 // code

not

@ABin-Huang
Copy link

When will this problem be fixed? If necessary, I can improve and submit the code.

@ChristopherSchultz
Copy link
Contributor Author

I reviewed this again a few months ago and, again, decided to push it off into the future.

Are you facing this particular issue? If so, it's good to have a user who can test potential fixes.

@ChristopherSchultz
Copy link
Contributor Author

@FSchumacher How does this PR look, now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants