DVO-205: (chore) replace golint (#321)

* chore: replace golint with revive

* style: fix revive reports

Author: Ricardo Lüders

.golangci.yml

@@ -6,7 +6,7 @@ linters:
   enable:
   - gofmt
   - goimports
-  - golint
+  - revive
   - govet
   - misspell
   - unused
@@ -18,10 +18,6 @@ linters:
   - staticcheck
 
 linters-settings:
-  golint:
-    # minimal confidence for issues, default is 0.8
-    min-confidence: 0
-
   lll:
     line-length: 120
     tab-width: 8

internal/testing/client.go

@@ -27,7 +27,7 @@ func (c *TestClient) Create(ctx context.Context, obj client.Object, opts ...Requ
 	}
 }
 
-func (c *TestClient) Update(ctx context.Context, obj client.Object, opts ...RequestOption) {
+func (c *TestClient) Update(ctx context.Context, obj client.Object, _ ...RequestOption) {
 	gomega.ExpectWithOffset(1, c.client.Update(ctx, obj)).Should(gomega.Succeed())
 }
 

pkg/prometheus/prometheus.go

@@ -171,6 +171,7 @@ func (s *Server) Start(ctx context.Context) error {
 	errCh := make(chan error)
 	drain := func() {
 		for range errCh {
+			continue
 		}
 	}