Skip to content

Improve comments #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kfeng123 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve comments #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openfold/model/primitives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,12 @@ def _prep_qkv(self,
k = self.linear_k(kv_x)
v = self.linear_v(kv_x)

# [*, Q/K, H, C_hidden]
# [*, Q/K/V, H, C_hidden]
q = q.view(q.shape[:-1] + (self.no_heads, -1))
k = k.view(k.shape[:-1] + (self.no_heads, -1))
v = v.view(v.shape[:-1] + (self.no_heads, -1))

# [*, H, Q/K, C_hidden]
# [*, H, Q/K/V, C_hidden]
q = q.transpose(-2, -3)
k = k.transpose(-2, -3)
v = v.transpose(-2, -3)
Expand Down
2 changes: 1 addition & 1 deletion openfold/model/triangular_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(
c_in:
Input channel dimension
c_hidden:
Overall hidden channel dimension (not per-head)
Per-head hidden channel dimension
no_heads:
Number of attention heads
"""
Expand Down