Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Feb 3, 2025

Update to latest release of Argo Rollouts: https://github.com/argoproj/argo-rollouts/releases/tag/v1.8.0
Before merging this PR, ensure you check the Argo Rollouts change logs and release notes:

  • Ensure there are no changes to the Argo Rollouts install YAML that we need to respond to with changes in the operator
    • You can do this by downloading the 'install.yaml' from both the previous version (for example, v1.7.1) and new version (for example, v1.7.2), and then comparing them using a tool like Meld or diff.
    • If there are changes to resources like Deployments and Roles in the install.yaml between the two versions, this will likely require a corresponding code change within the operator. e.g. a new permission added to a Role would require a change to the Role creation code in the operator.
  • Ensure there are no backwards incompatible API/behaviour changes in the change logs

Copy link

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fi

if [[ "`expr $DELTA_ERROR_RECONCILES \> 60`" == "1" ]]; then
if [[ "`expr $DELTA_ERROR_RECONCILES \> 70`" == "1" ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a small hint, if you want to test if that variable is greater than 70, you can also use the much simpler following construct :)

if [[ "$DELTA_ERROR_RECONCILES" -gt 70 ]]; then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jannfis! The bash scripts I write are 'hack' quality at best 😅.

@jgwest jgwest merged commit 38faac6 into argoproj-labs:main Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants