Skip to content

chore: Clean up test script with previous suggestion #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

chore: Clean up test script with previous suggestion #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hack/run-rollouts-manager-e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,22 +176,22 @@ sanity_test_metrics_data() {
# - If the number is higher, this implies we are updating the .status or .spec fields of resources more than is necessary.
PUT_REQUEST_PERCENT=`expr "$DELTA_PUT_REQUESTS"00 / $DELTA_POST_REQUESTS`

if [[ "`expr $PUT_REQUEST_PERCENT \> 40`" == "1" ]]; then
if [[ "$PUT_REQUEST_PERCENT" -gt 40 ]]; then
# This value is arbitrary, and should be updated if at any point it becomes inaccurate (but first audit the test/code to make sure it is not an actual product/test issue, before increasing)

echo "Put request was %$PUT_REQUEST_PERCENT greater than the expected value"
exit 1

fi

if [[ "`expr $DELTA_ERROR_RECONCILES \> 70`" == "1" ]]; then
if [[ "$DELTA_ERROR_RECONCILES" -gt 70 ]]; then
# This value is arbitrary, and should be updated if at any point it becomes inaccurate (but first audit the test/code to make sure it is not an actual product/test issue, before increasing)
echo "Number of Reconcile calls that returned an error '$DELTA_ERROR_RECONCILES' was greater than the expected value"
exit 1

fi

if [[ "`expr $DELTA_SUCCESS_RECONCILES \> 1200`" == "1" ]]; then
if [[ "$DELTA_SUCCESS_RECONCILES" -gt 1200 ]]; then
# This value is arbitrary, and should be updated if at any point it becomes inaccurate (but first audit the test/code to make sure it is not an actual product/test issue, before increasing)

echo "Number of Reconcile calls that returned success '$DELTA_SUCCESS_RECONCILES' was greater than the expected value"
Expand Down
Loading