Skip to content

Inconsistent logformat #1821

@ilabrovic

Description

@ilabrovic

Describe the bug
The logFormat option is inconsistently written between components. Some have logfomat, some have logFormat.

New options .spec.applicationSet.logformat and .spec.notifications.logformat were added in all lowercase.
But existing option .spec.controller.logFormat and in .spec.server.logFormat and .spec.repo.logFormat, were written with a capital 'F'.
This should be corrected to have argocd consistent options for logging: fieldnaming: logFormat

Looking at the desription (e.g. bundle/provided by oc explain, the description writes format with capital F.
So on that point there is more inconsistency.
(eg. config/crd/bases/argoproj.io_argocds.yaml about at line 1483)

So, were the latest 'logformat' field additions particularly written like that, or was it sloppy work?

To Reproduce
Steps to reproduce the behavior:

  1. oc explain argocd.spec.applicationSet -> logformat
  2. adding .spec.applicationSet.logformat works (but the field is inconsistent with logFormat from other argocd components.,
  3. adding .spec.applicationSet.logformat does NOT work

Expected behavior
logFormat should be written the same in all components.

Screenshots
Extract from oc explain argocd:
applicationSet
logformat --> added in 1.17, 'f' should be 'F'
controller
logFormat
notifications
logformat --> added in 1.17, 'f' should be 'F'
repo
logFormat
server
logFormat

Additional context
Having consistent fieldnames.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions