Skip to content

The PromotionStrategy controller produces previous-environment CommitStatus with an empty SHA #550

@crenshaw-dev

Description

@crenshaw-dev

That's a problem for two reasons:

  1. It doesn't make any sense. If we don't know the SHA for the CommitStatus, we just shouldn't create the CommitStatus. And it should probably be a reconciliation error.
  2. An empty SHA shouldn't be possible The CommitStatus sha field should have validation to ensure it's not empty.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions