feat: encapsulate snippet variables in uncaptured group #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in light of artisticat1#447 and artisticat1#367, it might not be obvious that snippetVariables should be encapsulated in an uncaptured group and since most use cases are \\${snippetVariable}, encapsulting makes writing easier for first time users. Users that somehow need it not encapsulated are probably skilled enough to remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in light of #447 and #367, it might not be obvious that snippetVariables should be encapsulated in an uncaptured group and since most use cases are \${snippetVariable}, encapsulting makes writing easier for first time users. Users that somehow need it not encapsulated are probably skilled enough to remove it
(resolves #447, why does github not have other words besides "fixing" a bug to indicate it fixes an issue...)