Fix #321 - don't pick up tests from other modules via aliases

Author: atilaneves

subpackages/runner/source/unit_threaded/runner/reflection.d

@@ -263,6 +263,8 @@ private TestData[] moduleUnitTests_(alias module_)() {
 
     void addUnitTestsRecursively(alias composite)() pure nothrow {
 
+        import std.traits: moduleName;
+
         if (composite.mangleof in visitedMembers)
             return;
 
@@ -272,25 +274,30 @@ private TestData[] moduleUnitTests_(alias module_)() {
         foreach(member; __traits(allMembers, composite)) {
 
             static if (
-                // If visibility of the member is deprecated, the next line still returns true
-                // and yet spills deprecation warning. If deprecation is turned into error,
-                // all works as intended.
+                // If visibility of the member is deprecated, the next
+                // line still returns true and yet spills deprecation
+                // warning. If deprecation is turned into error, all
+                // works as intended.
                 __traits(compiles, __traits(getMember, composite, member)) &&
                 __traits(compiles, __traits(allMembers, __traits(getMember, composite, member))) &&
-                __traits(compiles, recurse!(__traits(getMember, composite, member)))
+                __traits(compiles, recurse!(__traits(getMember, composite, member))) &&
+                moduleName!composite == moduleName!(__traits(getMember, composite, member))
+
             ) {
                 recurse!(__traits(getMember, composite, member));
             }
         }
     }
 
+
     void recurse(child)() pure nothrow {
         static if (is(child == class) || is(child == struct) || is(child == union)) {
             addUnitTestsRecursively!child;
         }
     }
 
     addUnitTestsRecursively!module_();
+
     return testData;
 }
 

tests/unit_threaded/ut/issues.d

@@ -414,3 +414,26 @@ else {
         nested().length.should == 0;
     }
 }
+
+
+version(unitThreadedLight) {}
+else {
+    @("321")
+    @system unittest {
+
+        import unit_threaded.runner.factory: createTestCases;
+        import std.algorithm: find, canFind;
+        import std.array: front;
+
+        enum testModule = "unit_threaded.ut.modules.issue321_helper";
+
+        const testData = allTestData!(
+            "unit_threaded.ut.modules.issue321",
+            "unit_threaded.ut.modules.issue321_helper",
+        );
+        auto tests = createTestCases(testData);
+        // there's only one unittest, and the bug was that it was
+        // being picked up twice due to an alias.
+        tests.length.should == 1;
+    }
+}

tests/unit_threaded/ut/modules/issue321.d

@@ -0,0 +1,8 @@
+module unit_threaded.ut.modules.issue321;
+
+
+struct Foo {
+    unittest {}
+}
+
+alias Zoo = Foo;

tests/unit_threaded/ut/modules/issue321_helper.d

@@ -0,0 +1,9 @@
+module unit_threaded.ut.modules.issue321_helper;
+
+import unit_threaded.ut.modules.issue321;
+
+struct Bar {
+    alias Bell = Foo;
+}
+
+alias Other = Foo;