test: correct usage of goleak.IgnoreCurrent()

Author: miparnisari

internal/services/integrationtesting/cert_test.go

@@ -38,7 +38,7 @@ import (
 )
 
 func TestCertRotation(t *testing.T) {
-	t.Parallel()
+	defer goleak.VerifyNone(t, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"))
 
 	const (
 		// length of time the initial cert is valid
@@ -284,5 +284,4 @@ func TestCertRotation(t *testing.T) {
 	case <-time.After(30 * time.Second):
 		require.Fail(t, "ungraceful server termination")
 	}
-	goleak.VerifyNone(t, goleak.IgnoreCurrent())
 }

internal/services/v1/permissions_test.go

@@ -646,10 +646,8 @@ func TestLookupResources(t *testing.T) {
 								tf.StandardDatastoreWithData,
 							)
 							client := v1.NewPermissionsServiceClient(conn)
-							t.Cleanup(func() {
-								goleak.VerifyNone(t, goleak.IgnoreCurrent())
-							})
-							t.Cleanup(cleanup)
+							defer goleak.VerifyNone(t, goleak.IgnoreCurrent())
+							defer cleanup()
 
 							var trailer metadata.MD
 							lookupClient, err := client.LookupResources(t.Context(), &v1.LookupResourcesRequest{
@@ -994,10 +992,8 @@ func TestLookupSubjects(t *testing.T) {
 					require := require.New(t)
 					conn, cleanup, _, revision := testserver.NewTestServer(require, delta, memdb.DisableGC, true, tf.StandardDatastoreWithData)
 					client := v1.NewPermissionsServiceClient(conn)
-					t.Cleanup(func() {
-						goleak.VerifyNone(t, goleak.IgnoreCurrent())
-					})
-					t.Cleanup(cleanup)
+					defer goleak.VerifyNone(t, goleak.IgnoreCurrent())
+					defer cleanup()
 
 					var trailer metadata.MD
 					lookupClient, err := client.LookupSubjects(t.Context(), &v1.LookupSubjectsRequest{
@@ -1670,10 +1666,8 @@ func TestLookupResourcesWithCursors(t *testing.T) {
 							require := require.New(t)
 							conn, cleanup, _, revision := testserver.NewTestServer(require, delta, memdb.DisableGC, true, tf.StandardDatastoreWithData)
 							client := v1.NewPermissionsServiceClient(conn)
-							t.Cleanup(func() {
-								goleak.VerifyNone(t, goleak.IgnoreCurrent())
-							})
-							t.Cleanup(cleanup)
+							defer goleak.VerifyNone(t, goleak.IgnoreCurrent())
+							defer cleanup()
 
 							var currentCursor *v1.Cursor
 							foundObjectIds := mapz.NewSet[string]()