Node Overlays - multiple price adjustments #8618
Description
Description
What problem are you trying to solve?
I opened #5033 2 years ago and with node overlays in Karpenter 1.7 I think we now have a solution to most of that problem. This is a great improvement, thanks for adding node overlays.
However, it seems that node overlays limit the number of price adjustments applied to a node to just 1. It would be beneficial to allow multiple price adjustments applied in a predictable order.
In my case, I would like to apply a % decrease for an enterprise discount, and then a fixed $ license fee for a vendor license fee. I don't think I can do that currently. The docs are currently somewhat ambiguous (see #8545), but I've tried this and it does not seem to work.
Another hypothetical but realistic case is where different per-node license fees are applied in independent and possibly-intersecting cases. For example, you might have a fixed per-node support fee that applies to all nodes; but you might also have some GPU-specific software that is only supported on an operating system with a per-server license fee, so there's an additional price incentive to consolidate GPU nodes. In some cases, then, you want to apply 2 adjustments, and in some cases 1 adjustment. It's desirable to manage these price adjustments as 2 distinct layers of overlays with intersecting requirements.
How important is this feature to you?
It's much less important to me than #5033 was, and just being able to apply one license fee is a big improvement. But the current limitation to a single price adjustment is surprising and doesn't seem necessary.
In my case if I could apply the % discount before the fixed $ license fee in Karpenter's node selections then I would get better cost efficiency. The license fee is proportionately more impactful on pricing when the % discount is preapplied.
I might be able to work around this by inverting the discount and applying that to the license fee in advance (so that the adjusted prices are proportionate with billed prices), but it's non-intuitive to other K8s cluster maintainers so I probably won't do that.
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
- Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment