feat: Adding ATX-FES apis support for transformation #2521

Rajanna-Karthik · 2025-11-22T02:14:46Z

feat: add atx fes integration for transform profiles
feat: implement Transform profile discovery via ATX FES with cache clearing
fix: remove unsupported eu-central-1 region from ATX FES endpoints
feat: add separate flow for RTS and ATX listavailableprofile api
fix: remove profile handling from atxnettransformserver
feat: separating qdev and aws transform
fix: fixing unit tests
fix: adding tests
fix: updating as per langugae server runtime updates
feat: add starttranform and workspace
feat: added getTransformInfo and its support methods
fix: with new runtimes
feat: add stopjob support
merged stopjob and added upload plan
chore: force use of new runtimes
fix: completed getting plan, worklogs, and final artifact
chore: deleting unused RPC messages
feat: added list worklogs before planning
fix: remove unused methods

Problem

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* feat: add atx fes integration for transform profiles * feat: implement Transform profile discovery via ATX FES with cache clearing * fix: remove unsupported eu-central-1 region from ATX FES endpoints * feat: add separate flow for RTS and ATX listavailableprofile api * fix: remove profile handling from atxnettransformserver * feat: separating qdev and aws transform * fix: fixing unit tests * fix: adding tests * fix: updating as per langugae server runtime updates * feat: add starttranform and workspace * feat: added getTransformInfo and its support methods * fix: with new runtimes * feat: add stopjob support * merged stopjob and added upload plan * chore: force use of new runtimes * fix: completed getting plan, worklogs, and final artifact * chore: deleting unused RPC messages * feat: added list worklogs before planning * fix: remove unused methods --------- Co-authored-by: Pranav Firake <[email protected]> Co-authored-by: pranav firake <[email protected]> Co-authored-by: Jordan Miao <[email protected]>

…servers into karsraja-atx-final

…and prevent us-east-1 defaults

…ob requests

…onstants

…servers into karsraja-atx-final

.../aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts.backup

…ase server is initialized

app/aws-lsp-antlr4-runtimes/package.json

XiaoxuanLu · 2025-11-24T21:55:21Z

app/aws-lsp-codewhisperer-runtimes/src/standalone-common.ts

        return {
            version,
-            servers: [AmazonQServiceServer, ...servers],
+            servers: [AmazonQServiceServer as any, ...servers],


why change this to as any

package-lock.json

rli · 2025-11-25T01:41:56Z

app/aws-lsp-codewhisperer-runtimes/src/standalone-common.ts

+export const createIAMRuntimeProps = createRuntimePropsFactory(AmazonQServiceServerIAM as any)
+export const createTokenRuntimeProps = createRuntimePropsFactory(AmazonQServiceServerToken as any)


why are there all these casts to any?

reverted this change.

we still have these casts in 4 files

core/aws-lsp-core/src/credentials/ideCredentialsProvider.ts

rli · 2025-11-25T01:44:39Z

server/aws-lsp-codewhisperer/src/shared/amazonQServer.ts

+            AtxTokenServiceManager.initInstance({
+                credentialsProvider,
+                lsp,
+                workspace,
+                logging,
+                runtime,
+                sdkInitializator,
+            })


reiterating my previous request that all ATX-related changes to initialized by isolated into its own server factory

yes Richard, we will refactor this as fast follow up iterm.

Could yo update the comments with Todo? We don't want this part to be forgotten in the codebase

rli · 2025-11-25T01:45:04Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

-     * PENDING_Q_PROFILE_UPDATE (only for identityCenter connection) waiting for Developer Profile to complete
-     * INITIALIZED - Service is initialized
-     */
+


can we keep this comment

rli · 2025-11-25T01:47:10Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

-        this.cancelActiveProfileChangeToken()
+        if (type === ('bearer' as CredentialsType)) {
+            // Only clear Q state when Q credentials are deleted
+            const hasQCredentials = this.features.credentialsProvider.hasCredentials('bearer' as CredentialsType)


i thought we established that both atx and q are of bearer tokens

reverted this change.

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

rli · 2025-11-25T01:48:23Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

+    public getAtxCodewhispererService(): CodeWhispererServiceToken {
+        throw new Error(
+            'ATX functionality has been moved to AtxTokenServiceManager. Use AtxTokenServiceManager.getInstance().getAtxCodewhispererService() instead.'
+        )
+    }


given that this was never in the q token manager service, why is this here?

reverted this change.

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

rli · 2025-11-25T01:49:32Z

.../aws-lsp-codewhisperer/src/language-server/netTransform/tests/AtxTokenServiceManager.test.ts

since this is not q, why is this in the q folder?

updated folder

awsTransform or netTransform? also should move AtxTokenServiceManager and atxTransformProfiles?

rli · 2025-11-25T01:52:06Z

app/aws-lsp-identity-runtimes/package.json

    },
    "dependencies": {
-        "@aws/language-server-runtimes": "0.3.6",
+        "@aws/language-server-runtimes": "0.3.8",


for all instances, use the caret notation. we rely on package-lock.json for the actual resolved version.

Suggested change

"@aws/language-server-runtimes": "0.3.8",

"@aws/language-server-runtimes": "^0.3.8",

updated this

rli · 2025-11-25T01:55:22Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AtxTokenServiceManager.test.ts

+        it('returns true when bearer-alternate credentials exist', () => {
+            features.credentialsProvider.hasCredentials.withArgs('bearer-alternate' as any).returns(true)


why do we still have all these references to 'bearer-alternate'? i thought this was now called 'atx-bearer'

reverted this change

XiaoxuanLu · 2025-11-25T02:33:26Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AtxTokenServiceManager.ts

+    public static initInstance(features: QServiceManagerFeatures): AtxTokenServiceManager {
+        if (!AtxTokenServiceManager.instance) {
+            AtxTokenServiceManager.instance = new AtxTokenServiceManager(features)
+            return AtxTokenServiceManager.instance
+        }
+        // throw new Error('ATX Token Service Manager already initialized')
+        return AtxTokenServiceManager.instance
+    }
+


this is a little bit concerned

codecov-commenter · 2025-11-25T04:28:09Z

Codecov Report

❌ Patch coverage is 15.91048% with 2743 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.13%. Comparing base (adb95de) to head (483b4b7).

Files with missing lines	Patch %	Lines
...anguage-server/netTransform/atxTransformHandler.ts	0.00%	1841 Missing ⚠️
...ed/amazonQServiceManager/AtxTokenServiceManager.ts	34.98%	249 Missing ⚠️
...ared/amazonQServiceManager/atxTransformProfiles.ts	0.00%	150 Missing ⚠️
...guage-server/netTransform/atxNetTransformServer.ts	0.00%	125 Missing ⚠️
...rver/configuration/transformConfigurationServer.ts	70.52%	117 Missing ⚠️
...erer/src/language-server/netTransform/atxModels.ts	0.00%	95 Missing ⚠️
.../aws-lsp-codewhisperer/src/shared/amazonQServer.ts	11.76%	45 Missing ⚠️
...mazonQServiceManager/AmazonQTokenServiceManager.ts	54.32%	37 Missing ⚠️
...amazonQServiceManager/BaseAmazonQServiceManager.ts	24.13%	22 Missing ⚠️
.../amazonQServiceManager/AmazonQIAMServiceManager.ts	10.52%	17 Missing ⚠️
... and 6 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   62.37%   60.13%   -2.25%     
==========================================
  Files         270      276       +6     
  Lines       61794    65004    +3210     
  Branches     4063     4111      +48     
==========================================
+ Hits        38546    39088     +542     
- Misses      23165    25833    +2668     
  Partials       83       83

Flag	Coverage Δ
unittests	`60.13% <15.91%> (-2.25%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rli · 2025-11-25T19:20:15Z

.../aws-lsp-codewhisperer/src/language-server/netTransform/tests/AtxTokenServiceManager.test.ts

awsTransform or netTransform? also should move AtxTokenServiceManager and atxTransformProfiles?

rli · 2025-11-25T19:21:37Z

app/aws-lsp-codewhisperer-runtimes/src/standalone-common.ts

+export const createIAMRuntimeProps = createRuntimePropsFactory(AmazonQServiceServerIAM as any)
+export const createTokenRuntimeProps = createRuntimePropsFactory(AmazonQServiceServerToken as any)


we still have these casts in 4 files

rli · 2025-11-25T19:22:12Z

app/hello-world-lsp-runtimes/package.json

    "dependencies": {
        "@aws/hello-world-lsp": "^0.0.1",
-        "@aws/language-server-runtimes": "0.3.6"
+        "@aws/language-server-runtimes": "0.3.8"


missed this one

updated both

rli · 2025-11-25T19:23:24Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

-     * PENDING_Q_PROFILE_UPDATE (only for identityCenter connection) waiting for Developer Profile to complete
-     * INITIALIZED - Service is initialized
-     */
+


can we keep this comment

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

rli · 2025-11-25T22:19:34Z

core/aws-lsp-core/src/credentials/ideCredentialsProvider.ts

    private pushedCredentials: IamCredentials | undefined
    private pushedToken: BearerToken | undefined

+    private pushedAtxCredentials: IamCredentials | undefined


Suggested change

private pushedAtxCredentials: IamCredentials | undefined

rli · 2025-11-25T22:20:22Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts

+            if (qCreds && 'token' in qCreds && qCreds.token) {
+                this.logging.log(`Q token updated: ${qCreds.token.substring(0, 20)}...`)
+            }


Suggested change

if (qCreds && 'token' in qCreds && qCreds.token) {

this.logging.log(`Q token updated: ${qCreds.token.substring(0, 20)}...`)

}

rli · 2025-11-25T22:21:00Z

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AtxTokenServiceManager.ts

+        const atxCredentialsProvider = runtime.getAtxCredentialsProvider()
+        this.log(`ATX credentials provider: ${!!atxCredentialsProvider}`)
+        const credentials = atxCredentialsProvider?.getCredentials('bearer')
+        this.log(`ATX credentials: ${!!credentials}`)


Suggested change

this.log(`ATX credentials: ${!!credentials}`)

Rajanna-Karthik requested a review from a team as a code owner November 22, 2025 02:14

fix: adding atxcredentials details

fd301ce

huawenm approved these changes Nov 22, 2025

View reviewed changes

Pranav Firake added 2 commits November 22, 2025 17:34

fix: updating plan for completed status

90f1003

fix: separating aws atx and q credentials storage

767206f

pranav-firake force-pushed the karsraja-atx-final branch from 90f1003 to 767206f Compare November 23, 2025 04:44

gzmiao8 and others added 7 commits November 22, 2025 21:07

Merge branch 'karsraja-atx-final' of https://github.com/aws/language-…

3537b6b

…servers into karsraja-atx-final

fix: changed customer_output to customer_input

14fc0fc

fix: added new atx-fes-client models to allow CUSTOMER_INPUT types

d06b72a

fix: multiple accounts token auth

1a28cce

fix: auto-sync transform profiles using TransformConfigurationServer …

c4c55b9

…and prevent us-east-1 defaults

fix: set default fallback transform request from net 8 to net 10

2406963

fix: changed back q flow to net 8, added target framework to create j…

e79b4d8

…ob requests

gzmiao8 changed the base branch from atx-features-reInvent to main November 24, 2025 19:59

gzmiao8 and others added 4 commits November 24, 2025 12:03

Merge branch 'main' into karsraja-atx-final

a640848

Merge branch 'main' into karsraja-atx-final

d5ca017

fix: updates aws-server-runtimes to 0.3.8 and added Syd endpoint to c…

23f19b6

…onstants

Merge branch 'karsraja-atx-final' of https://github.com/aws/language-…

ea4aa27

…servers into karsraja-atx-final

pranav-firake approved these changes Nov 24, 2025

View reviewed changes

fix: maintaining backwards compatibility

0ea885f

pranav-firake changed the title ~~Atx riv final (#2520)~~ Adding ATX-FES apis support for transformation Nov 24, 2025

XiaoxuanLu closed this Nov 24, 2025

XiaoxuanLu reopened this Nov 24, 2025

Pranav Firake and others added 4 commits November 24, 2025 16:24

fix: fixing failing test

6c18d5c

fix: fixing tests

6fdc795

fix: get endpoints by stage

2d39e9f

fix: regex for appUrl not handling gamma stage and return default region

fcf1f78

rli reviewed Nov 25, 2025

View reviewed changes

.../aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts.backup Outdated Show resolved Hide resolved

fix: fix for initInstance and moved init of atx servers to be after b…

1e7b76f

…ase server is initialized

XiaoxuanLu reviewed Nov 25, 2025

View reviewed changes

rli reviewed Nov 25, 2025

View reviewed changes

XiaoxuanLu reviewed Nov 25, 2025

View reviewed changes

Pranav Firake added 3 commits November 24, 2025 19:30

fix: fixing tests

c45dd1d

fix: fixing tests

60dec8d

fix: fixing tests

4488909

Pranav Firake added 4 commits November 24, 2025 20:50

chore: bumping lsp version to 0.3.8

7c21e0a

chore: revert naming from Q back to codewhisperer

0300cb8

chore: deleting stale function

4892fa5

chore: updating folder

5b5c31a

rli reviewed Nov 25, 2025

View reviewed changes

XiaoxuanLu reviewed Nov 25, 2025

View reviewed changes

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/AmazonQTokenServiceManager.ts Outdated Show resolved Hide resolved

gzmiao8 and others added 2 commits November 25, 2025 12:03

fix: changed transformserver to log caught errors instead of throwing

4758c21

chore: reverting changes and adding todo

6353ef2

pranav-firake force-pushed the karsraja-atx-final branch from fe41f3d to 6353ef2 Compare November 25, 2025 21:36

Pranav Firake added 2 commits November 25, 2025 13:52

fix: tests with changes

4054ee5

fix: tests with changes

ddc6b79

rli reviewed Nov 25, 2025

View reviewed changes

Pranav Firake and others added 2 commits November 25, 2025 15:08

chore: removing debug logs

e1fcaa8

Merge branch 'main' into karsraja-atx-final

483b4b7

rli approved these changes Nov 25, 2025

View reviewed changes

XiaoxuanLu approved these changes Nov 26, 2025

View reviewed changes

manodnyab changed the title ~~Adding ATX-FES apis support for transformation~~ feat: Adding ATX-FES apis support for transformation Nov 26, 2025

XiaoxuanLu merged commit 56ee489 into main Nov 26, 2025
10 of 11 checks passed

XiaoxuanLu deleted the karsraja-atx-final branch November 26, 2025 19:27

github-actions bot mentioned this pull request Nov 26, 2025

chore(release): release packages from branch main #2527

Merged

		export const createIAMRuntimeProps = createRuntimePropsFactory(AmazonQServiceServerIAM as any)
		export const createTokenRuntimeProps = createRuntimePropsFactory(AmazonQServiceServerToken as any)

	"@aws/language-server-runtimes": "0.3.8",
	"@aws/language-server-runtimes": "^0.3.8",

		it('returns true when bearer-alternate credentials exist', () => {
		features.credentialsProvider.hasCredentials.withArgs('bearer-alternate' as any).returns(true)

	if (qCreds && 'token' in qCreds && qCreds.token) {
	this.logging.log(`Q token updated: ${qCreds.token.substring(0, 20)}...`)
	}

feat: Adding ATX-FES apis support for transformation #2521

feat: Adding ATX-FES apis support for transformation #2521

Uh oh!

Conversation

Rajanna-Karthik commented Nov 22, 2025

Problem

Solution

License

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

codecov-commenter commented Nov 25, 2025 •

edited

Loading