fix pre-commit run

batmac · batmac · commit bcf4544a2df2 · 2024-07-16T19:28:55.000+02:00
diff --git a/.golangci.yml b/.golangci.yml
@@ -102,7 +102,7 @@ linters:
     # - structcheck
     - stylecheck
     - tagalign
-    - tagliatelle
+    # - tagliatelle
     - tenv
     - testableexamples
     - testpackage
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -65,7 +65,7 @@ repos:
       # - id: go-mod-tidy
       - id: golangci-lint # requires github.com/golangci/golangci-lint
         args:
-          ["--allow-parallel-runners", "--go=1.17", "--config=.golangci.yml"]
+          ["--allow-parallel-runners", "--config=.golangci.yml"]
   - repo: https://github.com/renovatebot/pre-commit-hooks
     rev: 37.421.0
     hooks:
diff --git a/cmd/ccat/memoryUsage_test.go b/cmd/ccat/memoryUsage_test.go
@@ -9,7 +9,7 @@ func TestPrintMemUsage(t *testing.T) {
 		{name: "donotpanicplease"},
 	}
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			PrintMemUsage()
 		})
 	}
diff --git a/cmd/ccat/processfile_test.go b/cmd/ccat/processfile_test.go
@@ -28,7 +28,7 @@ func Test_processFile(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			processFile(io.Discard, tt.args.path)
 			processFileAsIs(io.Discard, tt.args.path)
 		})
@@ -42,7 +42,7 @@ func Test_setError(t *testing.T) {
 		{"donotpanicplease"},
 	}
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			setErrored()
 		})
 	}
diff --git a/cmd/ccat/stdout_test.go b/cmd/ccat/stdout_test.go
@@ -3,7 +3,7 @@ package main
 import "testing"
 
 func Test_setupStdout(t *testing.T) {
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		_ = setupStdout(false)
 		_ = setupStdout(true)
 	})
diff --git a/cmd/ccat/ui_test.go b/cmd/ccat/ui_test.go
@@ -6,7 +6,7 @@ import (
 )
 
 func Test_uiWrapProcessFile(t *testing.T) {
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		_ = uiWrapProcessFile(func(io.Writer, string) {})
 	})
 }
diff --git a/magefiles/magefile.go b/magefiles/magefile.go
@@ -21,7 +21,7 @@ var Default = BuildDefaultAndTest
 var (
 	defaultBuildArgs = []string{"build"}
 	binaryName       = "ccat"
-	goBin			= mg.GoCmd()
+	goBin            = mg.GoCmd()
 )
 
 func init() {
diff --git a/pkg/color/color256.go b/pkg/color/color256.go
@@ -24,7 +24,7 @@ func (c C256) Sprint(s string) string {
 
 // #nosec
 func (c *C256) Next() Color {
-	rand.Seed(int64(*c))
-	n := C256(rand.Intn(230))
+	rand.Seed(int64(*c))      //nolint:staticcheck
+	n := C256(rand.Intn(230)) //nolint:gosec
 	return &n
 }
diff --git a/pkg/completion/common_test.go b/pkg/completion/common_test.go
@@ -19,7 +19,7 @@ func TestPrint(t *testing.T) {
 		{"bash", args{"bash", []string{}}},
 	}
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			completion.Print(tt.args.shell, tt.args.opts)
 		})
 	}
diff --git a/pkg/globalctx/context_test.go b/pkg/globalctx/context_test.go
@@ -22,7 +22,7 @@ var (
 
 func TestSet(t *testing.T) {
 	for _, tt := range testsGlobalCtx {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			globalctx.Set(tt.k, tt.v)
 		})
 	}
diff --git a/pkg/highlighter/chroma.go b/pkg/highlighter/chroma.go
@@ -9,7 +9,6 @@ import (
 	"math/rand"
 	"os"
 	"strings"
-	"time"
 
 	"github.com/batmac/ccat/pkg/log"
 	"github.com/batmac/ccat/pkg/stringutils"
@@ -96,7 +95,7 @@ func (h *Chroma) highLight(w io.WriteCloser, r io.ReadCloser, o Options) error {
 	stylesList := styles.Names()
 	switch {
 	case o.StyleHint == "random":
-		rand.Seed(time.Now().UnixNano())
+		// rand.Seed(time.Now().UnixNano())
 		//#nosec G404 (weak rand)
 		randStyle := rand.Intn(len(stylesList))
 		h.style = stylesList[randStyle]
diff --git a/pkg/miniclaude/messagesapi.go b/pkg/miniclaude/messagesapi.go
@@ -84,7 +84,7 @@ func (c *Request) Stream(mr *MessagesRequest) error {
 	if resp.StatusCode != http.StatusOK {
 		log.Printf("http unexpected status code: %s", resp.Status)
 		// dump the body
-		io.Copy(os.Stderr, resp.Body)
+		_, _ = io.Copy(os.Stderr, resp.Body)
 		return fmt.Errorf("http unexpected status code: %d (%s)", resp.StatusCode, resp.Status)
 	}
 
diff --git a/pkg/openers/http_test.go b/pkg/openers/http_test.go
@@ -25,7 +25,7 @@ var (
 )
 
 func init() {
-	rand.Seed(time.Now().UnixNano())
+	// rand.Seed(time.Now().UnixNano())
 
 	go func() {
 		// find an available port
diff --git a/pkg/openers/prng.go b/pkg/openers/prng.go
@@ -57,7 +57,7 @@ func (f prngOpener) Open(s string, _ bool) (io.ReadCloser, error) {
 			return nil, err
 		}
 	}
-	rand.Seed(seed)
+	rand.Seed(seed) //nolint:staticcheck
 	log.Debugf("seed : %d", seed)
 	pcg := pcg.NewPCG32(rand.Uint64(), rand.Uint64()) // #nosec
 	n := int64(0)
diff --git a/pkg/selfupdate/selfupdate_test.go b/pkg/selfupdate/selfupdate_test.go
@@ -7,7 +7,7 @@ import (
 )
 
 func Test_Do(t *testing.T) {
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		selfupdate.Do("v0+dev", "", selfupdate.ModeCheckOnly)
 		selfupdate.Do("100", "", selfupdate.ModeCheckOnly)
 	})
diff --git a/pkg/term/art_test.go b/pkg/term/art_test.go
@@ -54,7 +54,7 @@ func TestPrintArt(t *testing.T) {
 		{"gif", args{r}},
 	}
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			term.PrintArt(tt.args.r)
 		})
 	}
diff --git a/pkg/term/osc52_test.go b/pkg/term/osc52_test.go
@@ -8,7 +8,7 @@ import (
 
 func TestOsc52(t *testing.T) {
 	something := []byte("This is a test string from ccat testing (TestOsc52)")
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		term.Osc52(something)
 	})
 }
diff --git a/pkg/term/ssh_test.go b/pkg/term/ssh_test.go
@@ -7,7 +7,7 @@ import (
 )
 
 func TestIsSsh(t *testing.T) {
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		_ = term.IsSSH()
 	})
 }
diff --git a/pkg/term/term_test.go b/pkg/term/term_test.go
@@ -66,7 +66,7 @@ func TestGetTerminalSize(t *testing.T) {
 }
 
 func TestClearScreen(t *testing.T) {
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		term.ClearScreen()
 	})
 }
diff --git a/pkg/utils/isstringinfile_test.go b/pkg/utils/isstringinfile_test.go
@@ -14,7 +14,7 @@ func TestIsStringInFile(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	t.Run("donotpanicplease", func(t *testing.T) {
+	t.Run("donotpanicplease", func(_ *testing.T) {
 		got := utils.IsStringInFile(" ", exe)
 		log.Debugf("%v\n", got)
 	})

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ func TestPrintMemUsage(t *testing.T) {`
`9`	`9`	`{name: "donotpanicplease"},`
`10`	`10`	`}`
`11`	`11`	`for _, tt := range tests {`
`12`		`- t.Run(tt.name, func(t *testing.T) {`
	`12`	`+ t.Run(tt.name, func(_ *testing.T) {`
`13`	`13`	`PrintMemUsage()`
`14`	`14`	`})`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ func Test_processFile(t *testing.T) {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`for _, tt := range tests {`
`31`		`- t.Run(tt.name, func(t *testing.T) {`
	`31`	`+ t.Run(tt.name, func(_ *testing.T) {`
`32`	`32`	`processFile(io.Discard, tt.args.path)`
`33`	`33`	`processFileAsIs(io.Discard, tt.args.path)`
`34`	`34`	`})`
`@@ -42,7 +42,7 @@ func Test_setError(t *testing.T) {`
`42`	`42`	`{"donotpanicplease"},`
`43`	`43`	`}`
`44`	`44`	`for _, tt := range tests {`
`45`		`- t.Run(tt.name, func(t *testing.T) {`
	`45`	`+ t.Run(tt.name, func(_ *testing.T) {`
`46`	`46`	`setErrored()`
`47`	`47`	`})`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ import (`
`6`	`6`	`)`
`7`	`7`
`8`	`8`	`func Test_uiWrapProcessFile(t *testing.T) {`
`9`		`- t.Run("donotpanicplease", func(t *testing.T) {`
	`9`	`+ t.Run("donotpanicplease", func(_ *testing.T) {`
`10`	`10`	`_ = uiWrapProcessFile(func(io.Writer, string) {})`
`11`	`11`	`})`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ var Default = BuildDefaultAndTest`
`21`	`21`	`var (`
`22`	`22`	`defaultBuildArgs = []string{"build"}`
`23`	`23`	`binaryName = "ccat"`
`24`		`- goBin = mg.GoCmd()`
	`24`	`+ goBin = mg.GoCmd()`
`25`	`25`	`)`
`26`	`26`
`27`	`27`	`func init() {`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ func (c C256) Sprint(s string) string {`
`24`	`24`
`25`	`25`	`// #nosec`
`26`	`26`	`func (c *C256) Next() Color {`
`27`		`- rand.Seed(int64(*c))`
`28`		`- n := C256(rand.Intn(230))`
	`27`	`+ rand.Seed(int64(*c)) //nolint:staticcheck`
	`28`	`+ n := C256(rand.Intn(230)) //nolint:gosec`
`29`	`29`	`return &n`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ func TestPrint(t *testing.T) {`
`19`	`19`	`{"bash", args{"bash", []string{}}},`
`20`	`20`	`}`
`21`	`21`	`for _, tt := range tests {`
`22`		`- t.Run(tt.name, func(t *testing.T) {`
	`22`	`+ t.Run(tt.name, func(_ *testing.T) {`
`23`	`23`	`completion.Print(tt.args.shell, tt.args.opts)`
`24`	`24`	`})`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ var (`
`22`	`22`
`23`	`23`	`func TestSet(t *testing.T) {`
`24`	`24`	`for _, tt := range testsGlobalCtx {`
`25`		`- t.Run(tt.name, func(t *testing.T) {`
	`25`	`+ t.Run(tt.name, func(_ *testing.T) {`
`26`	`26`	`globalctx.Set(tt.k, tt.v)`
`27`	`27`	`})`
`28`	`28`	`}`