Skip to content

Commit d348f0c

Browse files
authored
Merge pull request #175 from bryanlatten/feature-dev-cleanup
Dockerfile: making use of (now) available pkgs
2 parents 31e2712 + 97a246e commit d348f0c

File tree

6 files changed

+43
-69
lines changed

6 files changed

+43
-69
lines changed

Dockerfile-7.0

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,28 +78,30 @@ RUN apt-get update -q && \
7878
php7.0-bcmath \
7979
php7.0-bz2 \
8080
php7.0-curl \
81-
php7.0-dev \
8281
php7.0-fpm \
8382
php7.0-gd \
8483
php7.0-igbinary \
8584
php7.0-intl \
8685
php7.0-json \
8786
php7.0-mbstring \
8887
php7.0-mcrypt \
89-
php7.0-pgsql \
9088
php7.0-memcache \
9189
php7.0-memcached \
92-
php7.0-mysql \
90+
php7.0-pgsql \
91+
php7.0-redis \
9392
php7.0-xdebug \
94-
php7.0-yaml \
9593
php7.0-xml \
94+
php7.0-yaml \
9695
php7.0-zip \
9796
newrelic-php5 \
9897
newrelic-php5-common \
9998
newrelic-daemon \
99+
# Order of operations issue is preventing this from being installed in alphabetical order
100+
php7.0-mysql \
100101
&& \
101102
phpdismod pdo_pgsql && \
102103
phpdismod pgsql && \
104+
phpdismod redis && \
103105
phpdismod yaml && \
104106
phpdismod xdebug && \
105107
# Remove extra extensions installed via packages for other versions of PHP, leaving the active engine folder
@@ -109,15 +111,11 @@ RUN apt-get update -q && \
109111
rm -rf /usr/lib/php/20170718 && \
110112
rm -rf /usr/lib/php/20180731 && \
111113
rm -rf /usr/lib/php/20190902 && \
114+
# Remove unused agents for other PHP versions
115+
cd /usr/lib/newrelic-php5/agent/x64 && ls | grep -v newrelic-20151012.so | xargs rm && \
116+
cd / && \
112117
curl -sS https://getcomposer.org/installer | php && \
113118
mv composer.phar /usr/local/bin/composer && \
114-
# Install new PHP7-stable version of Redis \
115-
pecl install redis && \
116-
echo "extension=redis.so" > $CONF_PHPMODS/redis.ini && \
117-
# Remove dev packages that were only in place just to compile extensions
118-
apt-get remove --purge -yq \
119-
php7.0-dev \
120-
&& \
121119
/bin/bash /clean.sh
122120

123121
# Overlay the root filesystem from this repo

Dockerfile-7.1

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,20 @@ RUN apt-get update -q && \
7878
php7.1-bcmath \
7979
php7.1-bz2 \
8080
php7.1-curl \
81-
php7.1-dev \
8281
php7.1-fpm \
8382
php7.1-gd \
8483
php7.1-igbinary \
8584
php7.1-intl \
8685
php7.1-json \
8786
php7.1-mbstring \
87+
php7.1-memcache \
88+
php7.1-memcached \
89+
php7.1-msgpack \
8890
php7.1-mcrypt \
8991
php7.1-mysql \
9092
php7.1-pgsql \
91-
php7.1-memcache \
92-
php7.1-memcached \
93+
php7.1-redis \
94+
php7.1-xdebug \
9395
php7.1-xml \
9496
php7.1-yaml \
9597
php7.1-zip \
@@ -100,6 +102,7 @@ RUN apt-get update -q && \
100102
&& \
101103
phpdismod pdo_pgsql && \
102104
phpdismod pgsql && \
105+
phpdismod redis && \
103106
phpdismod yaml && \
104107
phpdismod xdebug && \
105108
# Remove extra extensions installed via packages for other versions of PHP, leaving the active engine folder
@@ -109,16 +112,11 @@ RUN apt-get update -q && \
109112
rm -rf /usr/lib/php/20170718 && \
110113
rm -rf /usr/lib/php/20180731 && \
111114
rm -rf /usr/lib/php/20190902 && \
115+
# Remove unused agents for other PHP versions
116+
cd /usr/lib/newrelic-php5/agent/x64 && ls | grep -v newrelic-20160303.so | xargs rm && \
117+
cd / && \
112118
curl -sS https://getcomposer.org/installer | php && \
113119
mv composer.phar /usr/local/bin/composer && \
114-
# Install new stable versions of non-packaged extensions
115-
pecl-install \
116-
redis \
117-
&& \
118-
# Remove dev packages that were only in place just to compile extensions
119-
apt-get remove --purge -yq \
120-
php7.1-dev \
121-
&& \
122120
/bin/bash /clean.sh
123121

124122
# Overlay the root filesystem from this repo

Dockerfile-7.2

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ RUN apt-get update -q && \
7878
php7.2-bcmath \
7979
php7.2-bz2 \
8080
php7.2-curl \
81-
php7.2-dev \
8281
php7.2-fpm \
8382
php7.2-gd \
8483
php7.2-igbinary \
@@ -90,16 +89,18 @@ RUN apt-get update -q && \
9089
php7.2-msgpack \
9190
php7.2-mysql \
9291
php7.2-pgsql \
92+
php7.2-redis \
93+
php7.2-xdebug \
9394
php7.2-xml \
9495
php7.2-yaml \
9596
php7.2-zip \
96-
php-xdebug \
9797
newrelic-php5 \
9898
newrelic-php5-common \
9999
newrelic-daemon \
100100
&& \
101101
phpdismod pdo_pgsql && \
102102
phpdismod pgsql && \
103+
phpdismod redis && \
103104
phpdismod yaml && \
104105
phpdismod xdebug && \
105106
# Remove extra extensions installed via packages for other versions of PHP, leaving the active engine folder
@@ -109,16 +110,11 @@ RUN apt-get update -q && \
109110
rm -rf /usr/lib/php/20160303 && \
110111
rm -rf /usr/lib/php/20180731 && \
111112
rm -rf /usr/lib/php/20190902 && \
113+
# Remove unused agents for other PHP versions
114+
cd /usr/lib/newrelic-php5/agent/x64 && ls | grep -v newrelic-20170718.so | xargs rm && \
115+
cd / && \
112116
curl -sS https://getcomposer.org/installer | php && \
113117
mv composer.phar /usr/local/bin/composer && \
114-
# Install new stable versions of non-packaged extensions
115-
pecl-install \
116-
redis \
117-
&& \
118-
# Remove dev packages that were only in place just to compile extensions
119-
apt-get remove --purge -yq \
120-
php7.2-dev \
121-
&& \
122118
/bin/bash /clean.sh
123119

124120
# Overlay the root filesystem from this repo

Dockerfile-7.3

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ RUN apt-get update -q && \
7878
php7.3-bcmath \
7979
php7.3-bz2 \
8080
php7.3-curl \
81-
php7.3-dev \
8281
php7.3-fpm \
8382
php7.3-gd \
8483
php7.3-igbinary \
@@ -90,16 +89,18 @@ RUN apt-get update -q && \
9089
php7.3-msgpack \
9190
php7.3-mysql \
9291
php7.3-pgsql \
92+
php7.3-redis \
93+
php7.3-xdebug \
9394
php7.3-xml \
9495
php7.3-yaml \
9596
php7.3-zip \
96-
php-xdebug \
9797
newrelic-php5 \
9898
newrelic-php5-common \
9999
newrelic-daemon \
100100
&& \
101101
phpdismod pdo_pgsql && \
102102
phpdismod pgsql && \
103+
phpdismod redis && \
103104
phpdismod yaml && \
104105
phpdismod xdebug && \
105106
# Remove extra extensions installed via packages for other versions of PHP, leaving the active engine folder
@@ -109,16 +110,11 @@ RUN apt-get update -q && \
109110
rm -rf /usr/lib/php/20160303 && \
110111
rm -rf /usr/lib/php/20170718 && \
111112
rm -rf /usr/lib/php/20190902 && \
113+
# Remove unused agents for other PHP versions
114+
cd /usr/lib/newrelic-php5/agent/x64 && ls | grep -v newrelic-20180731.so | xargs rm && \
115+
cd / && \
112116
curl -sS https://getcomposer.org/installer | php && \
113117
mv composer.phar /usr/local/bin/composer && \
114-
# Install new stable versions of non-packaged extensions
115-
pecl-install \
116-
redis \
117-
&& \
118-
# Remove dev packages that were only in place just to compile extensions
119-
apt-get remove --purge -yq \
120-
php7.3-dev \
121-
&& \
122118
/bin/bash /clean.sh
123119

124120
# Overlay the root filesystem from this repo

Dockerfile-7.4

Lines changed: 11 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -77,32 +77,34 @@ RUN apt-get update -q && \
7777
&& \
7878
apt-get -yqq install \
7979
php7.4 \
80+
php7.4-apcu \
8081
php7.4-bcmath \
8182
php7.4-bz2 \
8283
php7.4-curl \
83-
php7.4-dev \
8484
php7.4-fpm \
8585
php7.4-gd \
86+
php7.4-igbinary \
8687
php7.4-intl \
8788
php7.4-json \
8889
php7.4-mbstring \
8990
php7.4-memcache \
91+
php7.4-memcached \
92+
php7.4-msgpack \
9093
php7.4-mysql \
9194
php7.4-pgsql \
95+
php7.4-redis \
9296
php7.4-xdebug \
9397
php7.4-xml \
98+
php7.4-yaml \
9499
php7.4-zip \
95100
newrelic-php5 \
96101
newrelic-php5-common \
97102
newrelic-daemon \
98-
# Temporary tweaks to support 7.4-beta
99-
libmemcached-dev \
100-
pkg-config \
101-
zlib1g-dev \
102-
libyaml-dev \
103103
&& \
104104
phpdismod pdo_pgsql && \
105105
phpdismod pgsql && \
106+
phpdismod redis && \
107+
phpdismod yaml && \
106108
phpdismod xdebug && \
107109
# Remove extra extensions installed via packages for other versions of PHP, leaving the active engine folder
108110
rm -rf /usr/lib/php/20121212 && \
@@ -112,27 +114,11 @@ RUN apt-get update -q && \
112114
rm -rf /usr/lib/php/20170718 && \
113115
rm -rf /usr/lib/php/20180731 && \
114116
rm -rf /usr/lib/php/7.3 && \
117+
# Remove unused agents for other PHP versions
118+
cd /usr/lib/newrelic-php5/agent/x64 && ls | grep -v newrelic-20190902.so | xargs rm && \
119+
cd / && \
115120
curl -sS https://getcomposer.org/installer | php && \
116121
mv composer.phar /usr/local/bin/composer && \
117-
# Install new stable versions of non-packaged extensions
118-
pecl-install \
119-
apcu \
120-
igbinary \
121-
redis \
122-
# memcache \
123-
memcached \
124-
msgpack \
125-
yaml \
126-
&& \
127-
phpenmod apcu igbinary memcached msgpack && \
128-
# Remove dev packages that were only in place just to compile extensions
129-
apt-get remove --purge -yq \
130-
php7.4-dev \
131-
build-essential \
132-
cpp \
133-
cpp-7 \
134-
gcc \
135-
&& \
136122
/bin/bash /clean.sh
137123

138124
# Overlay the root filesystem from this repo

container/root/tests/php-fpm/base.goss.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ command:
146146
php -n -d extension=pdo.so -d extension=pdo_pgsql.so -m | grep pdo_pgsql:
147147
exit-status: 0
148148
stderr: ['!/./']
149-
# On some variants, session is not loaded as part of the core, and must be loaded at this time
150-
php -n -d extension=session.so -d extension=json.so -d extension=redis.so -m | grep redis:
149+
# On some variants session, json, and igbinary are interwound - only create additive extension directives
150+
php extension=redis.so -m | grep redis:
151151
exit-status: 0
152152
# On session-default installs, re-loading session causes a warning, ignore
153153
# stderr: ['!/./']

0 commit comments

Comments
 (0)